Date: Mon, 16 Apr 2007 19:10:17 +0200 From: Pieter de Goeje <pieter@degoeje.nl> To: freebsd-hackers@freebsd.org Cc: Zhang Weiwu <zhangweiwu@realss.com> Subject: Re: a simple patch to enable RFC2640 for /usr/libexec/ftpd Message-ID: <200704161910.17794.pieter@degoeje.nl> In-Reply-To: <1176725221.17708.16.camel@joe.realss.com> References: <1176725221.17708.16.camel@joe.realss.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I think your patch looks good, however there have been some changes to ftpd= =20 since 6.1. Also, since lukemftp is imported from NetBSD, you might want to= =20 contact the original author so future imports won't discard this new featur= e. On Monday 16 April 2007, Zhang Weiwu wrote: > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 family =3D (family =3D=3D= AF_INET) ? AF_UNSPEC : > AF_INET6; break; > + > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 case '8': > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 utf8_mode =3D 1; Add missing break statement here? > =A0 > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 case 'a': > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 bindname =3D optarg; Cheers, Pieter de Goeje
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200704161910.17794.pieter>