Date: Mon, 7 May 2007 22:54:19 +0200 (CEST) From: Oliver Fromme <olli@lurza.secnetix.de> To: freebsd-current@FreeBSD.ORG, wkoszek@FreeBSD.ORG Subject: Re: INCLUDE_CONFIG_FILE patches Message-ID: <200705072054.l47KsJwg044996@lurza.secnetix.de> In-Reply-To: <20070506164247.GA77786@FreeBSD.czest.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
Wojciech A. Koszek wrote: > We talked about improved INCLUDE_CONFIG_FILE work some time ago. I > cleaned it up, and I have prepared a patch for the latest -CURRENT. > > It's here: > > http://people.freebsd.org/~wkoszek/patches/kernconf.patch > > If you have any suggestions, please let me know as I'd really like to > see this patch into the tree before RELENG_7. I'm currently unable to test the patch (lack of a working 7-current machine), but I've had a closer look at the patch anyway. Basically it looks very good. I just have one problem with it. It seems that it doesn't preserve comments and the exact formatting of the config file, right? (Please correct me if I'm wrong.) If that's true, that would be a regression. The current behaviour (i.e. with "strings ... | sed ...") reproduces the exact configuration file, with comments and everything. Best regards Oliver -- Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M. Handelsregister: Registergericht Muenchen, HRA 74606, Geschäftsfuehrung: secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mün- chen, HRB 125758, Geschäftsführer: Maik Bachmann, Olaf Erb, Ralf Gebhart FreeBSD-Dienstleistungen, -Produkte und mehr: http://www.secnetix.de/bsd 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.'
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200705072054.l47KsJwg044996>