Date: Wed, 4 Jul 2007 23:59:39 +0400
From: Andrey Chernov <ache@nagual.pp.ru>
To: "Sean C. Farley" <scf@FreeBSD.org>
Cc: freebsd-current <freebsd-current@FreeBSD.org>, Robert Watson <rwatson@FreeBSD.org>, Michal Mertl <mime@traveller.cz>
Subject: Re: Environment handling broken in /bin/sh with changes to {get,set,put}env()
Message-ID: <20070704195939.GA35302@nagual.pp.ru>
In-Reply-To: <20070704144159.X77978@thor.farley.org>
References: <1183557221.1799.16.camel@genius.i.cz> <20070704143642.GA31254@nagual.pp.ru> <20070704150312.GB31683@nagual.pp.ru> <20070704101026.O77978@thor.farley.org> <20070704173905.T67251@fledge.watson.org> <20070704121316.A77978@thor.farley.org> <20070704180000.GA34042@nagual.pp.ru> <20070704144159.X77978@thor.farley.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 04, 2007 at 02:47:50PM -0500, Sean C. Farley wrote: > My only concern is with programs (i.e., su) that "clean" the environment > after calling setenv(), putenv() or unsetenv(). I wrote a patch[1] (and > test program) that checks for a change of the address that environ is > pointing. If it detects a change, it scraps all that it knows about > environ (frees everything) and starts with the new environ. > > Of course, the sh patch[2] is still needed. > > Sean > 1. http://www.farley.org/freebsd/tmp/setenv/clearenv/ > 2. http://www.farley.org/freebsd/tmp/setenv/sh.patch Ah, good catch. I think this two needs to be commited ASAP to avoid more people reports. -- http://ache.pp.ru/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070704195939.GA35302>