Date: Sat, 14 Jul 2007 00:39:15 +0400
From: Andrey Chernov <ache@nagual.pp.ru>
To: "Sean C. Farley" <scf@FreeBSD.org>, freebsd-current <freebsd-current@FreeBSD.org>
Subject: Re: Environment handling broken in /bin/sh with changes to {get,set,put}env()
Message-ID: <20070713203915.GA20270@nagual.pp.ru>
In-Reply-To: <20070713202433.GA19856@nagual.pp.ru>
References: <20070707130859.GA96605@nagual.pp.ru> <20070707131359.GB96605@nagual.pp.ru> <20070707133102.C14065@thor.farley.org> <20070707191835.GA4368@nagual.pp.ru> <20070707205410.B14065@thor.farley.org> <20070708020940.GA80166@nagual.pp.ru> <20070708171727.GA90490@nagual.pp.ru> <20070713162742.GA16260@nagual.pp.ru> <20070713142545.K26096@thor.farley.org> <20070713202433.GA19856@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 14, 2007 at 12:24:33AM +0400, Andrey Chernov wrote:
> 1) I care in first hand about unsetenv() as my example states. There
> nowhere said in the specs that unsetenv() may modify environ _content_,
> manpage says about pointers only.
Moreover, they directly states (at least for some cases) that environment
should be left completely untouched, like that:
"If the named variable does not exist in the current environment, the
environment shall be unchanged and the function is considered to have
completed successfully."
> 2) That example not fail under FreeBSD 6 but fail under new code:
>
> nenv[0] = "PATH=/bin";
> nenv[1] = NULL;
> environ = nenv;
> setenv("HOME", "/xxx", 1);
Similar thing to the setenv example:
nenv[0] = "PATH=/bin";
setenv("PATH", "/bin", 0);
"If the environment variable named by envname already exists and the value
of overwrite is zero, the function shall return success and the
environment shall remain unchanged."
--
http://ache.pp.ru/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070713203915.GA20270>