Date: Sat, 14 Jul 2007 04:41:16 +0400 From: Andrey Chernov <ache@nagual.pp.ru> To: "Sean C. Farley" <scf@FreeBSD.org> Cc: freebsd-current <freebsd-current@FreeBSD.org> Subject: Re: Environment handling broken in /bin/sh with changes to t,set,put}env() Message-ID: <20070714004116.GA22909@nagual.pp.ru> In-Reply-To: <20070713184543.A26096@thor.farley.org> References: <20070707205410.B14065@thor.farley.org> <20070708020940.GA80166@nagual.pp.ru> <20070708171727.GA90490@nagual.pp.ru> <20070713162742.GA16260@nagual.pp.ru> <20070713142545.K26096@thor.farley.org> <20070713202433.GA19856@nagual.pp.ru> <20070713203915.GA20270@nagual.pp.ru> <20070713171942.Q26096@thor.farley.org> <20070713224608.GB21695@nagual.pp.ru> <20070713184543.A26096@thor.farley.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 13, 2007 at 07:08:37PM -0500, Sean C. Farley wrote:
> different. Are you saying that the addresses should not change for
> environ, environ[0-1] or all?
I try to say that *env() functions should avoid to change memory they not
"own" when it is possible and feel free to change the memory they "own".
What standard says is that initial copying all environ to the internal
structure and changing it afterwards (exluding putenv case) is
the right thing (because *env() functions "owns" that memory).
To avoid even things like
nenv[0] = "PATH=/bin";
setenv("PATH", "/bin", 1);
fails, better way is to strdup() (i.e. copying) every string from the
original environ and you already do that initially in build_env() but not
do the safe way in previous merge_environ().
BTW, I find that code in build_env() very suspicious:
if (environ[0] == NULL)
goto SaveEnviron;
...
SaveEnviron:
origEnviron = environ;
environ = NULL;
if (envVarsTotal > 0) {
...
} else
rtrnVal = 0;
return (rtrnVal);
It ends up with environ = NULL; because envVarsTotal initialized to 0 i.e.
makes from "environ[0] == NULL" case "environ == NULL" case which is
different thing.
--
http://ache.pp.ru/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070714004116.GA22909>