Date: Fri, 13 Jul 2007 22:27:52 -0500 From: Mike Karels <karels@karels.net> To: "Bruce M. Simpson" <bms@FreeBSD.org> Cc: Stephen.Clark@seclark.us, Sten Daniel Soersdal <netslists@gmail.com>, Julian Elischer <julian@elischer.org>, Bill Moran <wmoran@collaborativefusion.com>, freebsd-net@FreeBSD.org Subject: Re: 6.2 mtu now limits size of incomming packet Message-ID: <200707140327.l6E3RqWA007006@redrock.karels.net> In-Reply-To: Your message of Sat, 14 Jul 2007 03:30:54 %2B0100. <4698355E.2030707@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> In -CURRENT my changes to the ethernet input path maintain the use of > ETHER_MAX_FRAME() however the check is folded under #ifdef DIAGNOSTIC. I > don't recall adding this conditional or touching it so it seems to be > something which was already thereo radded by someone else. It has been there at least since 6.0. The issue is that ETHER_MAX_FRAME is computed using ifp->if_mtu, as opposed to something like ETHER_MAX_LEN. This is under #ifdef DIAGNOSTIC in -current, not in -stable. > Could be pilot error; its use in -CURRENT seems to apply strictly to the > use of large-receive offload (LRO). LRO relaxes the requirement, otherwise LRO packets would never pass the check. Mike
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200707140327.l6E3RqWA007006>