Date: Sun, 2 Dec 2007 15:09:20 +0100 From: Olivier Houchard <mlfbsd@ci0.org> To: Rafal Jaworowski <raj@semihalf.com> Cc: freebsd-arm@freebsd.org Subject: Re: ARM arch subdir cleanups Message-ID: <20071202140920.GA40640@ci0.org> In-Reply-To: <474FF9BF.8090707@semihalf.com> References: <474FF9BF.8090707@semihalf.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Nov 30, 2007 at 12:53:35PM +0100, Rafal Jaworowski wrote: > Hi, > Attached are two patches with the following cleanups: > > 1. Convert nexus to standard device since it's mandatory anyway, remove stale > nexus_io_asm.S and nexus_io.c > > 2. Streamline sys/conf/files.arm (and hence the kernel image contents): move > asm routines to appropriate sys/arm/<platform>/files.<platform> > > > It seems to me other items in the ARM arch subdirectory would benefit from > optimization/cleanups too, for example: > > - Shared OBIO routines. At least these are nearly identical and could be > compressed into one I guess: > > xscale/i80321/obio_space.c > xscale/i8134x/obio_space.c > xscale/pxa2x0/pxa2x0_space.c (in P4) > > - Shared bus space generic methods. A lot of BS methods like *_bs_map(), > _bs_subregion() etc. are copied in separate files for different ARM platforms, > but most of this could be placed in one file, just like we have a common > assembly routines in the arm/arm/bus_space_asm_generic.S. > > - Others like arm/arm/machdep.c and arm/arm/sys_machdep.c seem akin, could > they be merged into one file? > > I can work on cleaning those up, would such changes be welcome? > > Rafal Hi Rafal, I just committed your patches. Yes, this kind of work is very welcome. Thanks a lot ! Olivier
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071202140920.GA40640>