Date: Sun, 30 Dec 2007 20:37:18 +0100 From: Bernd Walter <ticso@cicely12.cicely.de> To: Mike Meyer <mwm@mired.org> Cc: freebsd-hackers@freebsd.org, ticso@cicely.de Subject: Re: Architectures with strict alignment? Message-ID: <20071230193718.GH31522@cicely12.cicely.de> In-Reply-To: <20071230135506.47beac58@bhuda.mired.org> References: <fl4c8o$vpu$1@ger.gmane.org> <20071229.122221.-432830441.imp@bsdimp.com> <20071229193034.GA73845@freebie.xs4all.nl> <86prwp161k.fsf@ds4.des.no> <20071230093432.GF31522@cicely12.cicely.de> <20071230135506.47beac58@bhuda.mired.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 30, 2007 at 01:55:06PM -0500, Mike Meyer wrote: > On Sun, 30 Dec 2007 10:34:33 +0100 Bernd Walter <ticso@cicely12.cicely.de> wrote: > > On Sat, Dec 29, 2007 at 11:37:27PM +0100, Dag-Erling Smørgrav wrote: > > > Wilko Bulte <wb@freebie.xs4all.nl> writes: > > > > In the past the alpha port had it too. > > > > > > No, it was optional and defaulted to off. > > > > It was never optional, since no alpha CPU can do missaligned access > > Alphas can fix missaligned access by software trap handlers in the same > > way as most other strong alignment architectures can and we did this > > for userland, but not in kernel. > > > Nevertheless it is horribly slow to do this, but was required since > > there was so many crappy software that days - fortunately this has > > changed over time, although I still see aligment traps on new software > > as well. > > Sadly said we never implemented missaligment traps for x86 so > [...] > > Ok, I'm a bit confused. Since you're talking about moving code from > the x86 to the alpha, I'm assuming you're talking about C code. Isn't > it the *compilers* job to enforce alignment issues, unless the > programmer specifically asks for byte-specific control of the layout > of a set of variables? Not in every case. It is not unusual to read raw bytes from e.g. network and use a struct pointer to it. But in case of network data it may be missaligned and if the struct contains anything else then bytes you may be doing missaligned accesses. > Or are these the issue, and the problem is that people do that and > then don't use the appropriate APIs to pull data from them, thus > causing you headaches? No - they just don't think about alignment when parsing data from random source. A very tricky case are IP headers in ethernet bytes - the ethernet header is not divideable by 4, but the IPs inside are 32 bit. Not to speak about the payload, which might contain 32 bit values. We have seen lots of missalignment bugs every now and then in ipfw, but now ipfw is aligment save since years now. I'm still not 100% sure if TCP NFS clients are save. At least in FreeBSD 5.x it is not. -- B.Walter http://www.bwct.de http://www.fizon.de bernd@bwct.de info@bwct.de support@fizon.de
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071230193718.GH31522>