Date: Tue, 4 Mar 2008 18:00:07 +0200 From: Giorgos Keramidas <keramida@ceid.upatras.gr> To: "M. Warner Losh" <imp@bsdimp.com> Cc: hackers@FreeBSD.org, rwatson@FreeBSD.org Subject: Re: Comments on pmake diffs for building on Linux Message-ID: <20080304160006.GB95950@kobe.laptop> In-Reply-To: <20080304.085245.2040341894.imp@bsdimp.com> References: <20080304.083350.1661915009.imp@bsdimp.com> <20080304153651.I41184@fledge.watson.org> <20080304154542.GC61036@kobe.laptop> <20080304.085245.2040341894.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2008-03-04 08:52, "M. Warner Losh" <imp@bsdimp.com> wrote: > In message: <20080304154542.GC61036@kobe.laptop> > Giorgos Keramidas <keramida@ceid.upatras.gr> writes: > : Nice! Thank you Robert. Can I copy parts of this and add them to the > : autoconf glue I'm adding now? > : > : To test just cpp(1) stuff, autoconf supports AC_PREPROC_IFELSE() too, > : which I used when I tried writing a check for __FBSDID(): > : > : AC_PREPROC_IFELSE( > : [AC_LANG_PROGRAM([[#include <sys/cdefs.h> > : #ifndef __FBSDID > : #error No __FBSDID definition. > : #endif]])], > : [AC_DEFINE([HAVE_FBSDID_MACRO], [1], > : [Define to 1 if you have the __FBSDID macro.])]) > : > : I can probably improve a bit the queue.h check using what you wrote > : above and AC_PREPROC_IFELSE(). > > The alternative to uglifying the make sources with #ifdefs would be to > just always use the compat includes when building... No autoconf > needed, and minimal changes to the base make, if any. True. I'll try to keep #ifdef changes down to the absolutely _minimum_ amount of changes. It will make repeated merged from usr.bin/make much easier, for example :)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080304160006.GB95950>