Date: Thu, 19 Jun 2008 03:50:03 GMT From: "Garrett Cooper" <yanefbsd@gmail.com> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/124723: Typo in error message in ggated.c Message-ID: <200806190350.m5J3o37a007822@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/124723; it has been noted by GNATS.
From: "Garrett Cooper" <yanefbsd@gmail.com>
To: "Hywel Mallett" <Hywel@hmallett.co.uk>
Cc: bug-followup@freebsd.org
Subject: Re: kern/124723: Typo in error message in ggated.c
Date: Wed, 18 Jun 2008 20:41:15 -0700
On Wed, Jun 18, 2008 at 9:44 AM, Hywel Mallett <Hywel@hmallett.co.uk> wrote:
>
>>Number: 124723
>>Category: kern
>>Synopsis: Typo in error message in ggated.c
>>Confidential: no
>>Severity: non-critical
>>Priority: low
>>Responsible: freebsd-bugs
>>State: open
>>Quarter:
>>Keywords:
>>Date-Required:
>>Class: sw-bug
>>Submitter-Id: current-users
>>Arrival-Date: Wed Jun 18 16:50:01 UTC 2008
>>Closed-Date:
>>Last-Modified:
>>Originator: Hywel Mallett
>>Release: 7-RELENG
>>Organization:
>>Environment:
> FreeBSD one.option13.co.uk 7.0-STABLE FreeBSD 7.0-STABLE #0: Sun May 4 19:43:28 BST 2008 hywel@one.option13.co.uk:/usr/obj/usr/src/sys/GENERIC amd64
>
>>Description:
> In ggated there is an error message "No enough memory", which should (probably) read "Not enough memory".
>>How-To-Repeat:
>
>>Fix:
> Patch for src/sbin/ggate/ggated/ggated.c attached
>
>
> Patch attached with submission follows:
>
> --- /usr/src/sbin/ggate/ggated/ggated.c 2006-12-18 11:12:00.000000000 +0000
> +++ ggated.c 2008-06-18 17:39:26.000000000 +0100
> @@ -211,10 +211,10 @@
>
> ex = malloc(sizeof(*ex));
> if (ex == NULL)
> - g_gate_xlog("No enough memory.");
> + g_gate_xlog("Not enough memory.");
> ex->e_path = strdup(path);
> if (ex->e_path == NULL)
> - g_gate_xlog("No enough memory.");
> + g_gate_xlog("Not enough memory.");
>
> /* Made 'and' here. */
> ex->e_ip = (ip & mask);
That error message (IMO) is in and of itself misleading.
strerror(errno) with g_gate_xlog(...) would be a more suitable means
of denoting the error encountered.
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200806190350.m5J3o37a007822>