Date: Fri, 25 Jul 2008 13:33:00 GMT From: Anselm Strauss <strauss@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 145885 for review Message-ID: <200807251333.m6PDX06I079276@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=145885 Change 145885 by strauss@strauss_marvelman on 2008/07/25 13:32:02 Cloning archive entry instead of referencing it for data descriptors (Tim) Affected files ... .. //depot/projects/soc2008/strauss_libarchive/libarchive/archive_write_set_format_zip.c#18 edit .. //depot/projects/soc2008/strauss_libarchive/libarchive/test/test_write_format_zip_no_compression.c#3 edit Differences ... ==== //depot/projects/soc2008/strauss_libarchive/libarchive/archive_write_set_format_zip.c#18 (text+ko) ==== @@ -173,7 +173,7 @@ archive_set_error(&a->archive, ENOMEM, "Can't allocate zip header data"); return (ARCHIVE_FATAL); } - l->entry = entry; /* TODO: Maybe bad idea, do copy or store only needed fields. */ + l->entry = archive_entry_clone(entry); l->next = zip->central_directory; zip->central_directory = l; ==== //depot/projects/soc2008/strauss_libarchive/libarchive/test/test_write_format_zip_no_compression.c#3 (text+ko) ====
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200807251333.m6PDX06I079276>