Date: Mon, 15 Sep 2008 18:08:33 -0400 From: John Baldwin <jhb@freebsd.org> To: Marcel Moolenaar <xcllnt@mac.com> Cc: freebsd-current@freebsd.org, Andriy Gapon <avg@icyb.net.ua> Subject: Re: sio => uart: one port is gone Message-ID: <200809151808.33400.jhb@freebsd.org> In-Reply-To: <1A6B5018-ABC9-4612-A66A-1A6D21336619@mac.com> References: <48CE59C2.9060307@icyb.net.ua> <48CEBF42.3060901@icyb.net.ua> <1A6B5018-ABC9-4612-A66A-1A6D21336619@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 15 September 2008 04:11:14 pm Marcel Moolenaar wrote: > > On Sep 15, 2008, at 1:02 PM, Andriy Gapon wrote: > > > --- a/sys/conf/files > > +++ b/sys/conf/files > > @@ -1080,7 +1080,7 @@ dev/twe/twe.c optional twe > > dev/twe/twe_freebsd.c optional twe > > dev/tx/if_tx.c optional tx > > dev/txp/if_txp.c optional txp > > -dev/uart/uart_bus_acpi.c optional uart acpi > > +dev/uart/uart_bus_acpi.c optional uart > > #dev/uart/uart_bus_cbus.c optional uart cbus > > dev/uart/uart_bus_ebus.c optional uart ebus > > dev/uart/uart_bus_isa.c optional uart isa > > This is exactly the thing we shouldn't be doing. > > You now compile the acpi bus attachment on platforms > that don't even have acpi. This is not a fix, it's > a breakage... You can change it in sys/conf/files.i386 instead. (It's ok to have duplicate lines across files*, the file gets compiled in if any one of the conditions matches). -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200809151808.33400.jhb>