Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 21 Sep 2008 08:14:34 GMT
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 150195 for review
Message-ID:  <200809210814.m8L8EY2a062176@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help

http://perforce.freebsd.org/chv.cgi?CH=150195

Change 150195 by hselasky@hselasky_laptop001 on 2008/09/21 08:13:42

	
	"usb2_proc_mwait()" should not be called locked.

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb2/controller/usb2_controller.c#13 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb2/controller/usb2_controller.c#13 (text+ko) ====

@@ -149,13 +149,13 @@
 	    &bus->detach_msg[0], &bus->detach_msg[1])) {
 		/* ignore */
 	}
-	mtx_unlock(&bus->mtx);
-
 	/* Wait for detach to complete */
 
 	usb2_proc_mwait(&bus->explore_proc,
 	    &bus->detach_msg[0], &bus->detach_msg[1]);
 
+	mtx_unlock(&bus->mtx);
+
 	/* Get rid of USB explore process */
 
 	usb2_proc_unsetup(&bus->explore_proc);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200809210814.m8L8EY2a062176>