Date: Fri, 10 Oct 2008 11:11:20 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: xcllnt@mac.com Cc: freebsd-arm@freebsd.org Subject: Re: FreeBSD/arm support for Marvell chips -- please review Message-ID: <20081010.111120.-1704377131.imp@bsdimp.com> In-Reply-To: <F2854257-4DC0-4812-8D04-F42DC44D8EFC@mac.com> References: <48DA31B3.5040906@semihalf.com> <48EF2481.2010307@semihalf.com> <F2854257-4DC0-4812-8D04-F42DC44D8EFC@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <F2854257-4DC0-4812-8D04-F42DC44D8EFC@mac.com>
Marcel Moolenaar <xcllnt@mac.com> writes:
:
: On Oct 10, 2008, at 2:46 AM, Rafal Jaworowski wrote:
:
: > Rafal Jaworowski wrote:
: >> All,
: >> With the recent series of submits in P4's arm-devel branch, I have
: >> completed
: >> import of FreeBSD/arm support for three families of Marvell
: >> integrated
: >> systems-on-chip built on ARMv5TE-compliant core. Orion support has
: >> been around
: >> for a while already, and recently added were extensions for
: >> Kirkwood and
: >> Discovery support, new drivers for integrated peripherals and other
: >> improvements.
: >>
: >> I'd like to merge this with SVN within the coming weeks, so would
: >> like to ask
: >> everyone to review the code and let me know about any comments or
: >> notes:
: >
: > I haven't received much feedback, are people still reviewing this?
:
: Just my $0.02:
:
: I personally don't like the deep nesting of directories,
: but other than that: it looks and works great.
I don't have a problem with the deep nesting of these directories. It
seems a good balance. The mips32/ extra layer in the mips port,
however, was just gratuitous. The xscale stuff isn't too bad either,
but sometimes feels a little deep. Each time I've looked at it,
however, I can't come up with anything better...
: I have some tweaks to add later. For example:
: FPA support on little endian ARM (FPA has the words in
: big-endian, irrespective of the byte order). We have
: 4 places where we define the IEEE representation and
: where we need to account for this.
FPA?
: FYI,
:
: --
: Marcel Moolenaar
: xcllnt@mac.com
:
:
:
: _______________________________________________
: freebsd-arm@freebsd.org mailing list
: http://lists.freebsd.org/mailman/listinfo/freebsd-arm
: To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org"
:
:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081010.111120.-1704377131.imp>