Date: Wed, 26 Nov 2008 00:48:45 +0200 From: Alex Kozlov <spam@rm-rf.kiev.ua> To: Tijl Coosemans <tijl@ulyssis.org>, Gerald Pfeifer <gerald@pfeifer.com>, freebsd-emulation@freebsd.org, Alex Kozlov <spam@rm-rf.kiev.ua> Subject: Re: wine-1.1.8 regression -- wine: could not load L"...": Invalid address Message-ID: <20081125224845.GA56243@ravenloft.kiev.ua>
next in thread | raw e-mail | index | archive | help
On Tue, Nov 25, 2008 at 11:26:23PM +0100, Tijl Coosemans wrote: >> Alex, would you mind submitting this patch upstream as well, to >> wine-patches@winehq.org Cc:ing me on that? (If you prefer, I can >> also do this, but since it's your patch...) >> >> I'm currently travelling and will try to update our port in the >> next couple of days; the earlier this gets upstream or at least >> upstream review the better. > It should probably first be discussed with Alexandre Julliard. The > original code fails because it ends up allocating the virtual heap > somewhere in the beginning of address space which probably interferes > with other mappings. > The patch moves this to (address_space_limit - 10 * VIRTUAL_HEAP_SIZE). > I'm not sure that's correct. I think simply 0x80000000 would be better, > but that's what Alexandre can tell you. I'm also not sure. That why this patch quick and dirty. Let see what Julliard has to say. > Also, in the #else case you change a 1 into a 0. Is that intentional? > - if (!wine_mmap_enum_reserved_areas( alloc_virtual_heap, &heap_base, 1 )) > + if (!wine_mmap_enum_reserved_areas( alloc_virtual_heap, &heap_base, 0 )) No, this is a mistake. -- Adios
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081125224845.GA56243>