Date: Sat, 13 Dec 2008 13:23:20 -0600 From: "Rick C. Petty" <rick-freebsd2008@kiwi-computer.com> To: Jaakko Heinonen <jh@saunalahti.fi> Cc: freebsd-fs@freebsd.org Subject: Re: UFS label limitations Message-ID: <20081213192320.GA97766@keira.kiwi-computer.com> In-Reply-To: <20081213183058.GA20992@a91-153-125-115.elisa-laajakaista.fi> References: <20081213173902.GA96883@keira.kiwi-computer.com> <20081213183058.GA20992@a91-153-125-115.elisa-laajakaista.fi>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Dec 13, 2008 at 08:30:59PM +0200, Jaakko Heinonen wrote: > > geom_label has problems with other characters too. The problem is that > it doesn't encode characters for XML output properly. See these PRs: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/104389 > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/120044 > > This already causes problems with file systems which allow non-ASCII > label names. IMO the problem should be addressed before extending > allowed characters in UFS labels. Well at the very least can we allow all characters between 0x20 and 0x7e except for: "&/<>\ Why hasn't the patch from kern/104389 made it in to geom? It's been almost 20 months since any activity on it. The last patch seems pretty good, except for NUL and SOH (0x00 and 0x01), but can't you just use "&#xx;" encoding for those also? XML has its own limitations. I don't think it's worth limiting everybody else just because of this XML bug. -- Rick C. Petty
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081213192320.GA97766>