Date: Tue, 23 Dec 2008 19:56:21 +0100 From: Hans Petter Selasky <hselasky@c2i.net> To: Ed Schouten <ed@80386.nl> Cc: Andrew Thompson <thompsa@freebsd.org>, freebsd-usb@freebsd.org Subject: Re: Giant on serial devices in USB2? Message-ID: <200812231956.21666.hselasky@c2i.net> In-Reply-To: <20081223175911.GZ1176@hoeg.nl> References: <20081223175911.GZ1176@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 23 December 2008, Ed Schouten wrote: > Hello HPS, others, > > I was just running a grep on the USB2 code and saw the following: > > $ grep -r Giant sys/dev/usb2/serial | wc -l > 70 > > WHat's the exact reason USB2 still uses Giant on TTY related drivers? > Couldn't it just use the per-TTY mutex? If not, maybe it should create a > custom system-wide mutex, instead of using Giant? > > Yours, Hi, I don't have all those USB devices at hand, so I simply cannot test if the driver still works without Giant. BTW: It should be trivial to remove Giant from the drivers. I think Andrew Thompson has already done some drivers Giant-free. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812231956.21666.hselasky>