Date: Wed, 11 Mar 2009 10:52:02 -0400 From: Wesley Shields <wxs@FreeBSD.org> To: Andriy Gapon <avg@icyb.net.ua> Cc: freebsd-ports@FreeBSD.ORG Subject: Re: request for a new port review [memtest86+] Message-ID: <20090311145202.GA85211@atarininja.org> In-Reply-To: <49B6A827.50705@icyb.net.ua> References: <49B6A827.50705@icyb.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 10, 2009 at 07:49:27PM +0200, Andriy Gapon wrote: > > Guys, > > could you please review the below port for correctness, style and > general approach taken by me. This is a port of memtest86+. Unlike > existing sysutils/memtest86 this port is not a > download/extraction/version-tracking aid, rather it is designed to > build a stand-alone ELF image (bootable by boot2 or loader) and/or an > ISO image from sources. The first option does not need any additional > justification, I think. The second option can be useful if you want to > add some local patches on top of vendor sources. > > I am very grateful for the idea for this port and many technical > details of it to Stephan Eisvogel. I also thank Eygene Ryabinkin for > teaching me some things about ld. > > Alternatives for /boot/opt are welcome :) > > P.S. Stephan, I plan to create a distinct port for your version very > soon. I am also considering making it a port option for this proposed > port, the option that would apply an extra patch. You seem to be using two tabs on every line. I think you should use only one. Just a style nit. I don't know if /boot/opt is the best place for it. It seems like /boot/local fits in better with the concept of /usr/local. Of course, it's just a name and I'm not attached strongly to any of them. What's wrong with making these changes to the existing memtest port, as OPTIONS? -- WXS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090311145202.GA85211>