Date: Fri, 10 Apr 2009 21:44:14 +0200 From: Polytropon <freebsd@edvax.de> To: vogelke+unix@pobox.com Cc: Gary Gatten <ggatten@waddell.com>, freebsd-questions@freebsd.org Subject: Re: sorta newb help compiling samba Message-ID: <20090410214414.acc2dc6d.freebsd@edvax.de> In-Reply-To: <20090410190237.27848BE71@kev.msw.wpafb.af.mil> References: <70C0964126D66F458E688618E1CD008A0793E92E@WADPEXV0.waddell.com> <20090410190237.27848BE71@kev.msw.wpafb.af.mil>
next in thread | previous in thread | raw e-mail | index | archive | help
Just a small sidenote according to your shell script:
You're defining
# echo without newline
necho () {
echo "$*" | tr -d '\012'
}
Why don't you use echo -n which suppresses the newline instead
of involving another program to do something that echo can do
on its own? This is how FreeBSD does it in its system scripts.
echo -n "Starting service... "
start_service
echo "done."
And according to
test -d /usr/bin || exit 0 # /usr not mounted
Woudln't it be more compliant to exit 1 to signal an error
due to /usr not being mounted? Exit code 0 is usually used
to signal that no error has happened (successful program
run), which isn't the case when the script is not (completely)
run.
--
Polytropon
>From Magdeburg, Germany
Happy FreeBSD user since 4.0
Andra moi ennepe, Mousa, ...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090410214414.acc2dc6d.freebsd>