Date: Mon, 25 May 2009 10:03:12 +0200 From: David Naylor <naylor.b.david@gmail.com> To: "Ion-Mihai Tetcu" <itetcu@freebsd.org> Cc: pgollucci@p6m7g8.com, pav@freebsd.org, freebsd-ports@freebsd.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) Message-ID: <200905251003.15408.naylor.b.david@gmail.com> In-Reply-To: <20090524223745.4bbc5420@it.buh.tecnik93.com> References: <20090523.182426.193741786.chat95@mac.com> <200905241026.26903.naylor.b.david@gmail.com> <20090524223745.4bbc5420@it.buh.tecnik93.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart10027487.IJtn7OL74c
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
On Sunday 24 May 2009 21:37:45 Ion-Mihai Tetcu wrote:
> On Sun, 24 May 2009 10:26:23 +0200
>
> David Naylor <naylor.b.david@gmail.com> wrote:
> > On Sunday 24 May 2009 00:16:37 Maho NAKATA wrote:
> > > Hi I tested it yesterday,
> > >
> > > 1.
> > > I need
> > >
> > > > MAKE_JOBS_SAFE=3D yes
> > >
> > > in the Makefile.
> >
> > Yes, you would need that. I believe that will be default.
> >
> > > 2. with above patch, ooo2 doesn't launch parallele jobs.
> >
> > I spotted that problem after submitting the patch, if you explicitly
> > set MAKE_JOBS_NUMBER to something it will work.
> >
> > The problem is that ooo2 does (in effect):
> > .if (${MAKE_JOBS_NUMBER} > 1)
> > # Stuff
> > .else
> > # Other stuff
> > .endif
> > and that doesn't work as expected with MAKE_JOBS_NUMBER=3D`sysctl
> > kern.smp.cpus` as the command is not resolved.
>
> w/o patch
> editors/openoffice.org-3 openoffice.org-3.1.0 4:53:27
>
> with patch:
> + MAKE_JOBS_SAFE=3D yes
> + MAKE_JOBS_NUMBER=3D 4
> + MAXPROCESSES?=3D ${MAKE_JOBS_NUMBER}
> + MAXMODULES?=3D ${MAKE_JOBS_NUMBER}
>
> editors/openoffice.org-3 openoffice.org-3.1.0 48:51
>
> The build is done in
> /dev/md0 on /usr/local/tinderbox/7-STABLE-FPT-NPD (ufs, asynchronous,
> local, noatime)
Wow, that is quite a speedup. Is it even possible (4 * 60 + 53)/4 =3D 73, =
and=20
you get 48 (that is 152% scaling efficiency). This would mean a serious=20
performance problem with the ooo3 build script and MAX* =3D1. =20
I'll make a patch tonight (+10 hours) that will fix ooo2 in the default cas=
e. =20
You can test ooo2 with patch and MAKE_JOBS_NUMBER preset (not using default=
=20
value) and MAKE_JOBS_SAFE=3Dyes.
Thanks for testing
--nextPart10027487.IJtn7OL74c
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)
iEYEABECAAYFAkoaUMMACgkQUaaFgP9pFrKO9gCfZO2hddIE/TVXe3nRiDhjmoDC
eLEAn3SD6XWh2CCJSUZksLBgyiob+zu+
=G+un
-----END PGP SIGNATURE-----
--nextPart10027487.IJtn7OL74c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200905251003.15408.naylor.b.david>