Date: Thu, 15 Oct 2009 16:19:39 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: dougb@FreeBSD.org Cc: markm@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: svn commit: r197790 - head/etc Message-ID: <20091015.161939.200967153.hrs@allbsd.org> In-Reply-To: <4AD3A722.9060401@FreeBSD.org> References: <200910052011.n95KBXdS024044@svn.freebsd.org> <4AD3A722.9060401@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Hi Doug,
Doug Barton <dougb@FreeBSD.org> wrote
in <4AD3A722.9060401@FreeBSD.org>:
do> I think this is the wrong solution to the problem. In at least two
do> cases (routed and route6d) where $command is not defined in the rc.d
do> scripts this change is resulting in $command not being defined at all.
do>
do> If you look at the definition of the + parameter substitution this
do> makes sense:
do>
do> ${parameter:+word}
do> Use Alternate Value. If parameter is unset or null, null
do> is substituted; otherwise, the expansion of word is
do> substituted.
do>
do> I think that what you really wanted to do was:
I am sorry for the delay. Your patch is reasonable to me. This
problem was there for a while, so it should be fixed asap.
I noticed there was something wrong about ${name}_program but it
seems I mistakenly changed it (sorry...). Then I received a report
"it does not work" so I just reverted it.
IMO defining $command in rc.d scripts is not a good practice.
"Always use ${name}_program and let load_rc_config() set the
$command" would be consistent and useful to avoid this sort of
problems.
-- Hiroki
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEABECAAYFAkrWzQsACgkQTyzT2CeTzy29/wCgv1dMPJJswx6WCfaLMyQbw8jI
EVwAoJPQ0IC03SMxZ5QnZJEHXWPFoXzI
=+z5p
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091015.161939.200967153.hrs>