Date: Thu, 5 Nov 2009 13:28:34 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Giovanni Trematerra <giovanni.trematerra@gmail.com> Cc: Attilio Rao <attilio@freebsd.org>, des@des.no, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: [PATCH] AMD Opteron Rev. E hack Message-ID: <20091105112834.GR2331@deviant.kiev.zoral.com.ua> In-Reply-To: <4e6cba830911050302k56bed35aj5ca9fa16379ab325@mail.gmail.com> References: <4e6cba830911050302k56bed35aj5ca9fa16379ab325@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Bi+HF1AHjw0mn3zx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 05, 2009 at 12:02:39PM +0100, Giovanni Trematerra wrote: > Hi, > I have a quick and dirty patch to address the problem as discussed on > commit r198868 in svn-src-head@ > I introduced BROKEN_OPTERON_E kernel option for i386/amd64 arch. > The patch isn't tested yet, I only successfully compiled on i386. > Can you let me know if the patch is on the right direction to resolve the issue? > style(9) tips are welcomed. I think there is no much sense in printing that hack in unused; instead, you should print info when option is enabled and vulnerable CPU is detected. Aren't atomic_readandclear need the same workaround ? It would be much easier to read the patch if you generated it with analog of "svn diff -x -p" for your VCS. --Bi+HF1AHjw0mn3zx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkrytuIACgkQC3+MBN1Mb4gcAwCeLgX6gTbM3CP7fSNxc82yjP95 PFkAnRWduCsbqL7cdEs31CURhh6RIv0N =GUh7 -----END PGP SIGNATURE----- --Bi+HF1AHjw0mn3zx--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091105112834.GR2331>