Date: Sun, 31 Jan 2010 12:06:18 +1100 From: Peter Jeremy <peterjeremy@acm.org> To: Marius Strobl <marius@alchemy.franken.de> Cc: rmacklem@freebsd.org, dfr@freebsd.org, freebsd-stable@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: uma_zalloc_arg complaining about non-sleepable locks Message-ID: <20100131010618.GA1864@server.vk2pj.dyndns.org> In-Reply-To: <20100127115229.GD40779@alchemy.franken.de> References: <20100126073336.GA1955@server.vk2pj.dyndns.org> <201001260946.44977.jhb@freebsd.org> <20100126183756.GA40779@alchemy.franken.de> <201001261510.59667.jhb@freebsd.org> <20100127063649.GA1889@server.vk2pj.dyndns.org> <20100127115229.GD40779@alchemy.franken.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Sorry for the delay, I was trying to avoid rebooting my server. I've setup a similar environment in VirtualBox to test it. On 2010-Jan-27 12:52:29 +0100, Marius Strobl <marius@alchemy.franken.de> wr= ote: >Ah, I forgot that using nfsm_aligned() causes nfs_realign() to >be a NOP on architectures without strict alignment requirements >for performance reasons. That's generally fine but unfortunately >that way you don't actually exercise the code which caused the >problem before (unfortunately I still don't manage to hit the >unaligned case myself). >Could you please test with #ifdef __NO_STRICT_ALIGNMENT replaced >with #if 0 in sys/nfs/nfs_common.h? The vfs.nfs.realign_count >counter should also increase then. I'm not sure what triggers the unaligned case either - I tried roughly "tar -cf - -C /mnt/usr src | tar -xf - -C /mnt/tmp" and that caused some unaligned accesses (but also completely wedged the VBox host). I also tried copying a pile of files off my NFS client (FreeBSD-8.x/i386) and that also triggered some unaligned accesses without any errors being reported. Currently, I have: vfs.nfs.realign_count: 12 vfs.nfs.realign_test: 188817 I'd say that your patch works. --=20 Peter Jeremy --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAktk14oACgkQ/opHv/APuIeisgCePxY3sndE6CGY8tE4mczcl/h6 GhwAn2JbZL6GMfbgMmksUrCuASTaFbRW =1AQN -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100131010618.GA1864>