Date: Tue, 2 Feb 2010 06:28:19 -0800 From: Jeremy Chadwick <freebsd@jdc.parodius.com> To: freebsd-stable@freebsd.org Subject: Re: patch for /usr/bin/mail Message-ID: <20100202142819.GA71870@icarus.home.lan> In-Reply-To: <E1NcJdQ-000Lv0-1W@dilbert.ticketswitch.com> References: <E1NcJdQ-000Lv0-1W@dilbert.ticketswitch.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 02, 2010 at 02:21:44PM +0000, Pete French wrote:
> This patch fixes a problem of mail missing addresses when replying
> to emails generated by some Microsoft systems, which do not insert a
> space after the comma in lists of addresses. Was filed as PR bin/131861
> If anyone who still uses /usr/bin/mail as their primarly email client
> could test it then I would be grateful (would also be garetful if
> someone could volunteer to commit it shold it prove to work fine :-) )
>
> -pete.
>
> --- usr.bin/mail/util.c.orig 2010-02-02 14:10:34.220987358 +0000
> +++ usr.bin/mail/util.c 2010-02-02 14:12:49.968147827 +0000
> @@ -496,10 +496,10 @@
> *cp2++ = ' ';
> }
> *cp2++ = c;
> - if (c == ',' && *cp == ' ' && !gotlt) {
> + if (c == ',' && (*cp == ' ' || *cp == '"') && !gotlt) {
> *cp2++ = ' ';
> - while (*++cp == ' ')
> - ;
> + while (*cp == ' ')
> + cp++;
> lastsp = 0;
> bufend = cp2;
> }
For what it's worth: note that Outlook, by default, uses semi-colon as
its delimiter between addresses in To/Cc/Bcc fields. The SMTP portion
of the Exchange interface might turn these into commas though, but I'm
not 100% certain (I'd have to manually check -- let me know if you want
me to).
--
| Jeremy Chadwick jdc@parodius.com |
| Parodius Networking http://www.parodius.com/ |
| UNIX Systems Administrator Mountain View, CA, USA |
| Making life hard for others since 1977. PGP: 4BD6C0CB |
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100202142819.GA71870>