Date: Tue, 16 Feb 2010 21:54:40 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Attilio Rao <attilio@freebsd.org> Cc: FreeBSD Arch <arch@freebsd.org>, Ed Maste <emaste@sandvine.com> Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch Message-ID: <20100216195440.GF50403@deviant.kiev.zoral.com.ua> In-Reply-To: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--+SfteS7bOf3dGlBC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote: > The following patch: > http://www.freebsd.org/~attilio/x86.diff >=20 > starts the effort for having a shared sub-tree between amd64 and ia32. > In this initial pass I putted the low-hanging fruits (bios/cpufreq) > and what my customer was more interested in (isa/*) in order to > kick-off the effort and, in the future, move gradually the code there. > With the machine/isa/* cleanup about 10 files are trimmed and I'm sure > more can be achieved easilly. > There are few things to discuss. One, that I had not necessity to dig > about still, is about how to organize headers (include/). Maybe some > replication ala pc98 may be good. >=20 > The patch is big but it is mostly added and removed files (look at the > files.X in order to understand better how files movements happened). >=20 > Hope to see comments and reviews. IMO the diff is unreadable. I suggest to do actual svn cp (not svn mv) operation now, without a review, and post a diff that should be applied to x86/ directory, as well as to build glue. The small proposition I have is to #define read_eflags() read_rflags() for amd64. --+SfteS7bOf3dGlBC Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkt6+AAACgkQC3+MBN1Mb4hqbACbBB+fo9TKiGOMcOtyEaOkmeMN IEQAoMXiY3VwVWi5HJinqBGQWtPOWMYp =g2EY -----END PGP SIGNATURE----- --+SfteS7bOf3dGlBC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100216195440.GF50403>