Date: Thu, 25 Mar 2010 10:56:15 +0100 From: Alexander Leidinger <Alexander@Leidinger.net> To: John Baldwin <jhb@freebsd.org> Cc: rwatson@freebsd.org, freebsd-arch@freebsd.org Subject: Re: CTF patch for testing/review Message-ID: <20100325105615.10186jr08a5oj00s@webmail.leidinger.net> In-Reply-To: <201003241132.29588.jhb@freebsd.org> References: <20100322.125937.278730673160410010.imp@bsdimp.com> <201003241005.55239.jhb@freebsd.org> <20100324154214.16865r6wk0r22rcw@webmail.leidinger.net> <201003241132.29588.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting John Baldwin <jhb@freebsd.org> (from Wed, 24 Mar 2010 11:32:29 -0400):
> On Wednesday 24 March 2010 10:42:14 am Alexander Leidinger wrote:
>> Quoting John Baldwin <jhb@freebsd.org> (from Wed, 24 Mar 2010 10:05:55
> -0400):
>>
>> > On Wednesday 24 March 2010 9:59:41 am Alexander Leidinger wrote:
>>
>> >> Currently I have the problem that WITH_CTF is not picked up by kmod.mk
>> >> if "makeoptions WITH_CTF=yes" is used in the kernel config. This means
>> >> that all makeoptions do not propagate to module builds.
>> >>
>> >> Any ideas?
>> >
>> > Hmmmm. That's odd because 'DEBUG=-g' does work. Ah, I think you should
>> > patch kern.post.mk to propogate WITH_CTF to modules. This is how it works
>> > for DEBUG now:
>> >
>> > .if defined(DEBUG)
>> > MKMODULESENV+= DEBUG_FLAGS="${DEBUG}"
>> > .endif
>>
>> Do we want to be able to override WITH_CTF in modules (-> kern.pre.mk
>> instead of kernl.post.mk)?
>
> No, I think it is fine to treat it the same as DEBUG.
DEBUG is in kern.pre.mk, and thus can be overriden. Currently I have
WITH_CTF handling in kern.post.mk, and thus it can not be overriden.
There are some MKMODULESENV things in post.mk already.
On a related note, the LD_CTF_FLAGS thing does not seem to work for
modules. Reading the man page of ld tells that -g is a noop (the
switch is ignored). Thus I would prefer to remove the setting of -g
for ld. Any objections?
>> While I'm here, do we want to have CONF_CFLAGS used in modules too? I
>> would expect that they are used there (I use it to use -fno-builtin
>> for my kernel build) and would put it into kern.post.mk.
>
> Hmm, probably yes. That should be a separate commit however.
I agree.
Bye,
Alexander.
--
These days the necessities of life cost you about three times what
they used to, and half the time they aren't even fit to drink.
http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100325105615.10186jr08a5oj00s>