Date: Fri, 28 May 2010 14:45:57 +0200 From: Jilles Tjoelker <jilles@stack.nl> To: Ed Schouten <ed@80386.nl> Cc: freebsd-bugs@FreeBSD.org, Guy Yur <guyyur@gmail.com>, brucec@FreeBSD.org Subject: Re: bin/146916: [patch] sh(1) uses dumb terminal in single-user mode Message-ID: <20100528124557.GA50785@stack.nl> In-Reply-To: <20100528103830.GK56080@hoeg.nl> References: <201005281033.o4SAXjlv078228@freefall.freebsd.org> <20100528103618.GJ56080@hoeg.nl> <20100528103830.GK56080@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 28, 2010 at 12:38:30PM +0200, Ed Schouten wrote: > * Ed Schouten <ed@80386.nl> wrote: > > Why should the shell be responsible for this? Shouldn't we put stuff > > like this in /sbin/init? > Oh wait. Never mind. I understand the issue. Jilles, what do you think > about this? Yes, I think init(8) should attempt to pass a suitable TERM to the single-user shell. This value could be hard-coded (TERM=xterm will usually be close enough) or taken from /etc/ttys somehow. The sh(1) patch to allow updating libedit's TERM looks OK, although it probably should not react to TERM changes in subshells. I do not plan to revert r206182, putting 'set -o emacs' in root's shell startup files instead. I did 'set -o emacs' in the shell itself so that it works even if there are no startup files at all, such as 'make buildenv' and chroot shells. -- Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100528124557.GA50785>