Date: Mon, 21 Jun 2010 00:26:35 +0900 From: Norikatsu Shigemura <nork@FreeBSD.org> To: Alexander Motin <mav@FreeBSD.org> Cc: Rafal Jaworowski <raj@FreeBSD.org>, freebsd-arm@FreeBSD.org, Warner Losh <imp@FreeBSD.org>, nork@FreeBSD.org Subject: Re: OpenRD-Client/Ultimate support Message-ID: <20100621002635.d6d8876b.nork@FreeBSD.org> In-Reply-To: <4C1E182C.9080009@FreeBSD.org> References: <20100620220302.8eb84547.nork@FreeBSD.org> <4C1E182C.9080009@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi mav.
On Sun, 20 Jun 2010 16:31:24 +0300
Alexander Motin <mav@FreeBSD.org> wrote:
> > mvs(4):
> > 5. FDT-ish
> If I understand right, with FDT SOC part of mvs(4) driver is no longer
> need to be named "sata" to attach to the bus. If possible, I would
> prefer it to be renamed to "mvs", same as PCI one.
like following?
mvs.c
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
+ if (!ofw_bus_is_compatible(dev, "mvs"))
+ return (ENXIO);
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
openrd-cl.dts
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
sata@80000 {
compatible = "mrvl,sata", "mvs";
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
or
openrd-cl.dts
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
sata@80000 {
compatible = "mrvl,sata";
device_type = "sata";
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
I'll try device_type = "sata" on sata@80000.
> Also some not very related cosmetic for the bus: wouldn't it be nice to
> export device "compatible" string to newbus as "pnpinfo" and something
> (may be section name) as "location" string?
I don't know FDT description style.
Rafal, how about do you think?
--
Norikatsu Shigemura <nork@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100621002635.d6d8876b.nork>