Date: Wed, 14 Jul 2010 21:57:31 +1000 From: Andrew Reilly <areilly@bigpond.net.au> To: Pawel Worach <pawel.worach@gmail.com> Cc: scsi@freebsd.org Subject: Re: [patch] fix aicasm build with clang. Message-ID: <20100714115731.GA14537@duncan.reilly.home> In-Reply-To: <51186C1C-E61D-4A9D-8A78-749F48E89CE0@gmail.com> References: <51186C1C-E61D-4A9D-8A78-749F48E89CE0@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 14, 2010 at 11:44:57AM +0200, Pawel Worach wrote: > sys/dev/aic7xxx/aicasm/aicasm_gram.y:1826:51: error: use of logical || with constant operand; switch to bitwise | or remove constant [-Wlogical-bitwise-confusion] > if (opcode == AIC_OP_AND || opcode == AIC_OP_JNZ || AIC_OP_JZ) > ^ ~~~~~~~~~ > > Bug ? Looks like one to me. There's no constant value of AIC_OP_JZ that can make its inclusion in that line interesting, as is (it is probably non-zero, which means that the if-body is always executed. I think that your patch is almost certainly correct. [What down-stream effect does this bug have on the SCSI controller microcode in question?] Cheers, -- Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100714115731.GA14537>