Date: Mon, 19 Jul 2010 18:22:02 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: yohanes@gmail.com Cc: freebsd-arm@FreeBSD.org, ticso@cicely.de Subject: Re: at91sam9g20: Upcoming Patches Message-ID: <20100719.182202.918765004097971572.imp@bsdimp.com> In-Reply-To: <AANLkTilj6crfPkCfViYU8LkFxZ6LY8WxRAghiZXaSDn_@mail.gmail.com> References: <4C444E8B.6090104@ansley.com> <20100719153614.GI28908@cicely7.cicely.de> <AANLkTilj6crfPkCfViYU8LkFxZ6LY8WxRAghiZXaSDn_@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <AANLkTilj6crfPkCfViYU8LkFxZ6LY8WxRAghiZXaSDn_@mail.gmail.c=
om>
Yohanes Nugroho <yohanes@gmail.com> writes:
: On Mon, Jul 19, 2010 at 10:36 PM, Bernd Walter <ticso@cicely7.cicely.=
de> wrote:
: >> if_ate.c:
: >>
: >> =A0 =A0* Support for sam9 "EMAC" controller.
: >> =A0 =A0* Support for rmii interface to phy.
: >
: > RM9200 ate requires specific DMA alignment, which required a few
: > realign copys.
: > This isn't neccessary for most other AT91 devices and for sure
: > not with any AT91SAM9x device.
: > Not sure if all of them are automatically avoided - you might want
: > to verify the code about this point.
: > There is also RBNA workaround, which should be RM9200 specifc,
: > which shouldn't be triggered with others, but you might want to sav=
e
: > a few bytes codespace.
: =
: And looking at Linux's code, they separate for the RM9200 driver and
: newer AT9 (macb) drivers. I haven't looked deeply, but it seems that
: if we are going to support all variations of RM9200 PHY for link
: checking purpose, there will a lot of RM9200 specific code.
Unlike Linux, all that's abstracted out in FreeBSD, so it is easy to
support dozens of different PYHs. In fact, I don't think there's any
PHY specific code in the current ATE driver...
: I agree that there are many things in common between these two
: drivers, but I don't know if it is a good idea to keep everything in
: one file.
Yea, I worry about the performance on newer parts of the older code,
which has stinky performance due to hardware limitations.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100719.182202.918765004097971572.imp>