Date: Mon, 23 Aug 2010 15:47:23 +0200 From: Ed Schouten <ed@80386.nl> To: Kostik Belousov <kostikbel@gmail.com> Cc: Ian FREISLICH <ianf@clue.co.za>, freebsd-current@freebsd.org Subject: Re: fusefs-kmod broken? Message-ID: <20100823134723.GC64651@hoeg.nl> In-Reply-To: <20100823134459.GF2396@deviant.kiev.zoral.com.ua> References: <201008230826.49509.jhb@freebsd.org> <E1OmUBI-0000Oy-J5@clue.co.za> <E1OnWc7-0001Kv-47@clue.co.za> <20100823132551.GE2396@deviant.kiev.zoral.com.ua> <20100823133555.GA64651@hoeg.nl> <20100823134459.GF2396@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--JgQwtEuHJzHdouWu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Kostik Belousov <kostikbel@gmail.com> wrote: > On Mon, Aug 23, 2010 at 03:35:55PM +0200, Ed Schouten wrote: > > * Kostik Belousov <kostikbel@gmail.com> wrote: > > > Which most likely means that fusesfs filled its own struct fileops > > > without properly initializing fo_truncate member. > >=20 > > It's a bit misleading that cdevs automatically patch the table, while > > the fileops don't. Maybe it would be a good idea to patch finit() to > I do not understand your first sentence. Would you please elaborate ? Say, you create a cdev, if you don't implement all ops, it will check for null pointers and return error codes accordingly. This doesn't happen for fileops, which is probably one of the reasons why people sometimes forget to implement them. Wouldn't it be better to prevent this form of footshooting by adding assertions? This will add some overhead for any file descriptor created, but a kernel with INVARIANTS isn't meant to be fast. --=20 Ed Schouten <ed@80386.nl> WWW: http://80386.nl/ --JgQwtEuHJzHdouWu Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iEYEARECAAYFAkxye+sACgkQ52SDGA2eCwXtewCfeU4xVL5Q5bEYTTGDTntIhpwY n6kAnibyW8f9geMMz1zsMmgw2L8UulKV =hxFa -----END PGP SIGNATURE----- --JgQwtEuHJzHdouWu--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100823134723.GC64651>