Date: Fri, 1 Oct 2010 23:02:01 -0700 From: "David O'Brien" <obrien@NUXI.org> To: Rob Farmer <rfarmer@predatorlabs.net> Cc: David DEMELIER <demelier.david@gmail.com>, FreeBSD Ports <ports@freebsd.org>, Wesley Shields <wxs@freebsd.org> Subject: Re: editors/vim installs to / Message-ID: <20101002060201.GA8287@dragon.NUXI.org> In-Reply-To: <AANLkTik9GhTDUkjfu5rqPf9d7JjNyUisNGGTMKU9F1uG@mail.gmail.com> References: <4C93AA31.5080202@DataIX.net> <AANLkTik%2B1rvY4ZYgzHRjaX8PBfD1UqNCNeadHqg3KBfo@mail.gmail.com> <20100917205404.GA66620@atarininja.org> <AANLkTikUa0ikQLT%2BgxFXGZO3OyXomXzzBFb2Q65Dsoes@mail.gmail.com> <20100917232437.GC67059@atarininja.org> <AANLkTik9GhTDUkjfu5rqPf9d7JjNyUisNGGTMKU9F1uG@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 17, 2010 at 05:38:21PM -0700, Rob Farmer wrote:
> However, I still think it would benefit everyone if the maintainer
> could provide an explanation for some of the current behavior and
> would at least be open to discussion about changing it. The biggest
> problem here, IMHO, is not the OPTIONS issue, but rather the use of
> GTK 1 as the default.
I have commented on GTK2 (explained) in the past.
It is the kitchen sink that gtk2 brings in vs. gtk1. On my desktop
gtk2 requires 64 other packages. gtk1 requires 20.
I guess its time to take another survey. Is Vim one of the few last
gtk1 consumers?
For gtk1, I have 13 packages that require it. For gtk2, I have 49
packages that require it. So I agree their are significantly more ports
that depend on gtk2 -- and thus little way to avoid having it installed
on one's system.
> I think either defaulting to GTK 2 or just making vim a
> console application would eliminate most of these complaints.
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/editors/vim/Makefile,v
retrieving revision 1.362
diff -u -p -u -1 -r1.362 Makefile
--- Makefile 2 Oct 2010 01:55:08 -0000 1.362
+++ Makefile 2 Oct 2010 06:00:34 -0000
@@ -40,3 +43,3 @@ SLAVEDIRS= editors/vim-lite
-CONFLICTS= vim6* vim*-lite
+CONFLICTS= vim6* vim*-lite vim*-gtk1 vim*-gnome
MAKE_JOBS_SAFE= yes
@@ -126,4 +129,4 @@ MAKE_ARGS+= CONF_OPT_TCL="--enable-tclin
# for now default the GUI to the GTK+ one
-. if !defined(WITH_X11_ONLY) && !defined(WITH_ATHENA) && !defined(WITH_MOTIF) && !defined(WITH_GNOME) && !defined(WITH_GTK) && !defined(WITH_GTK2)
-WITH_GTK= yes
+. if !defined(WITH_X11_ONLY) && !defined(WITH_ATHENA) && !defined(WITH_MOTIF) && !defined(WITH_GNOME) && !defined(WITH_GTK1) && !defined(WITH_GTK2)
+WITH_GTK2= yes
. endif
@@ -132,3 +135,3 @@ WITH_GTK= yes
MAKE_ARGS+= CONF_OPT_GUI="--enable-gui=athena" ${I18N}
-. elif defined(WITH_GTK)
+. elif defined(WITH_GTK1)
USE_GNOME= gtk12
@@ -137,5 +140,5 @@ MAKE_ARGS+= X_LIBS="$(X_LIBS) -lXt"
USE_XORG+= xt
+PKGNAMESUFFIX= -gtk1
. elif defined(WITH_GTK2)
USE_GNOME= gtk20
-PKGNAMESUFFIX= -gtk2
MAKE_ARGS+= CONF_OPT_GUI="--enable-gui=gtk2 --with-gtk-prefix=${LOCALBASE}" ${I18N}
@@ -257,2 +260,8 @@ show-options:
+.if defined(WITH_GTK)
+.BEGIN:
+ @${ECHO_CMD} "WITH_GTK has been renamed WITH_GTK1."
+ @exit 1
+.endif
+
cklatest:
Thoughts?
--
-- David (obrien@NUXI.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101002060201.GA8287>