Date: Wed, 22 Jun 2011 16:02:33 +0300 From: Ion-Mihai Tetcu <itetcu@FreeBSD.org> To: Chris Rees <crees@freebsd.org> Cc: ports@freebsd.org, "Ilya A. Arkhipov" <micro@heavennet.ru>, Alexey Dokuchaev <danfe@freebsd.org>, kwm@freebsd.org Subject: Re: OpenTTD Message-ID: <20110622160233.8b6156e1.itetcu@FreeBSD.org> In-Reply-To: <BANLkTi=s6zYOJJv6%2Bkk%2Bttd7jadmTuaT6w@mail.gmail.com> References: <20110621214013.6cc4760e@heavennet.ru> <20110622020048.GA83940@FreeBSD.org> <BANLkTi=En%2B7nJgEmKCmBEQMwiV0nbcPhEg@mail.gmail.com> <20110622064224.GB94185@FreeBSD.org> <BANLkTi=s6zYOJJv6%2Bkk%2Bttd7jadmTuaT6w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 22 Jun 2011 09:56:55 +0100 Chris Rees <crees@freebsd.org> wrote: > 2011/6/22 Alexey Dokuchaev <danfe@freebsd.org>: > > On Wed, Jun 22, 2011 at 10:33:14AM +0400, Ilya A. Arkhipov wrote: > >> Ok i rewrite patch and do with argument, and write patch to portlint ;) > > > > Wow, if you could write a patch to portlint that is would correctly suggest > > that MAINTAINER/COMMENT/LICENSE should be grouped together, and FOO_DEPENDS > > would be closed to USE_BAR knobs, I'd be very grateful! > > > > Just to make myself clear on this issue: COMMENT/LICENSE are general > > software information, FOO_DEPENDS and USE_BAR knobs both specify > > dependencies (that is, package-related stuff). I believe that it does not > > make sence to mix them, hence LICENSE should be defined before _DEPENDS, not > > after. > > > > I agree 110% with this. It confused me a while ago when I started to > use LICENSE, but I think the general acceptance is that we should > have: > > PORTNAME > PORTVERSION > etc > > MAINTAINER > COMMENT > > LICENSE > > So license in a separate block; you can have several license lines > making the MAINTAINER/COMMENT block unnecessarily large. > > Not too sure about keeping _DEPENDS with USE; there're additional > variables often set with USE, perhaps a block for _DEPENDS and then > USE etc underneath? (could follow with USERS/GROUPS). > > Example: > > PORTNAME > PORTVERSION > etc > > MAINTAINER > COMMENT > > LICENSE > > LIB_DEPENDS= > > BUILD_DEPENDS= > > RUN_DEPENDS= > > USE_FOO > FOO_ARGS > USE_BAR > > USERS > GROUPS *dEPENDS and USE* are really the same thing, dependencies (with, maybe, some rare exceptions). So I'd say they should go together. -- Ion-Mihai Tetcu <itetcu@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110622160233.8b6156e1.itetcu>