Date: Wed, 24 Aug 2011 23:14:27 +0200 From: Jilles Tjoelker <jilles@stack.nl> To: gk@freebsd.org Cc: svn-src-projects@freebsd.org, Matthew D Fleming <mdf@FreeBSD.org>, src-committers@freebsd.org Subject: Re: svn commit: r225097 - in projects/ino64: include lib/libc/gen usr.sbin/cpucontrol usr.sbin/lpr/common_source usr.sbin/newsyslog Message-ID: <20110824211427.GB96070@stack.nl> In-Reply-To: <201108222354.p7MNsC9B074753@svn.freebsd.org> References: <201108222354.p7MNsC9B074753@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 22, 2011 at 11:54:12PM +0000, Matthew D Fleming wrote: > Author: mdf > Date: Mon Aug 22 23:54:12 2011 > New Revision: 225097 > URL: http://svn.freebsd.org/changeset/base/225097 > Log: > Avoid using dirfd name there is dirfd() macro already. > Use dirfd() instead of dirp->dd_fd. > Replace dirfd() macro with exported libc symbol. > Use _dirfd() macro internally. > GSoC r222835, r222836, r222837. > Code by Gleb Kurtsou. > Added: projects/ino64/lib/libc/gen/dirfd.c > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ projects/ino64/lib/libc/gen/dirfd.c Mon Aug 22 23:54:12 2011 (r225097) [snip] > +int > +dirfd(DIR *dirp) > +{ > + if (dirp == NULL) > + return (-1); > + > + return (_dirfd(dirp)); > +} Why have this check here? I think the original behaviour (a segfault) is more useful here since the return value of this interface is often not checked. -- Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110824211427.GB96070>