Date: Fri, 14 Oct 2011 08:56:09 +0000 From: Alexander Best <arundel@freebsd.org> To: Nikolay Denev <ndenev@gmail.com> Cc: FreeBSD Current <freebsd-current@freebsd.org>, Arnaud Lacombe <lacombar@gmail.com> Subject: Re: [RFC] Prepend timestamp in msgbuf Message-ID: <20111014085609.GA3799@freebsd.org> In-Reply-To: <45812C38-5FD2-43C4-825E-94B0E03A7AA6@gmail.com> References: <4e972734.52b1e00a.15ed.ffffd873@mx.google.com> <CACqU3MWxn0rvbL5d7Vot35A%2BpfMDMEQdqmDgAaUABwzTxoH41Q@mail.gmail.com> <45812C38-5FD2-43C4-825E-94B0E03A7AA6@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri Oct 14 11, Nikolay Denev wrote: > > On Oct 13, 2011, at 9:40 PM, Arnaud Lacombe wrote: > > > Hi, > > > > On Thu, Oct 13, 2011 at 2:00 PM, <lacombar@gmail.com> wrote: > >> From: Arnaud Lacombe <lacombar@gmail.com> > >> > >> Hi folks, > >> > >> There is many case recently when I really wished timestamp were present in the > >> post-mortem msgbuf. Such situation could be when userland application segfault > >> potentially triggering a panic/crash, or have information about the time-wise > >> location of a given message (kernel or userland). > >> > >> Attached patch is available in the git repository at: > >> git://github.com/lacombar/freebsd.git master/topic/msgbuf-timestamp > >> > >> Arnaud Lacombe (3): > >> msgbuf(4): convert `msg_needsnl' to a bit flag > >> msgbuf(4): add logic to prepend timestamp on new line > >> msgbuf(4): add a sysctl to toggle timestamp prepend > >> > >> sys/kern/subr_msgbuf.c | 53 ++++++++++++++++++++++++++++++++++++++++------- > >> sys/sys/msgbuf.h | 4 ++- > >> 2 files changed, 48 insertions(+), 9 deletions(-) > >> > > Cool! > > I've dreamt for something like this for a long time, it can be very useful. great work! a have a few comments however: 1) would it be possible to prepend those timestamps to the actual console output and not only to the output of demsg? maybe via a sysctl toggle? 2) my dmesg output contains a lot of these entries: "<118>" 3) roughly the first 30 lines of my dmesg output have the timestamp "[1.0]". would it be possible to have more accuracy there? 4) maybe a new dmesg flag would be a good idea to suppress timestamps. cheers. alex > > Regards, > Nikolay >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111014085609.GA3799>