Date: Sun, 15 Apr 2012 11:08:08 +0000 From: Alexander Best <arundel@freebsd.org> To: freebsd-fs@freebsd.org Subject: fixing a hackish comment in ata-raid.c Message-ID: <20120415110807.GA75306@freebsd.org>
next in thread | raw e-mail | index | archive | help
--Dxnq1zWXvFF0Q93v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
hi there,
clang complains about this rather ugly way of putting a comment into normal
code:
if ((vdcr == NULL) /* && (sa == NULL) * Spares not supported yet */) {
could somebody please commit the following (or a similar) patch?
thanks in advance.
alex
--Dxnq1zWXvFF0Q93v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="ata-raid.c.patch"
diff --git a/sys/dev/ata/ata-raid.c b/sys/dev/ata/ata-raid.c
index c96e252..f7215d3 100644
--- a/sys/dev/ata/ata-raid.c
+++ b/sys/dev/ata/ata-raid.c
@@ -1892,7 +1892,12 @@ ata_raid_ddf_read_meta(device_t dev, struct ar_softc **raidp)
}
}
cr_found:
- if ((vdcr == NULL) /* && (sa == NULL) * Spares not supported yet */) {
+ /* Spares are not supported yet.
+ * Once support is implemented the condition below should be:
+ *
+ * if ((vdcr == NULL) && (sa == NULL)) {
+ */
+ if (vdcr == NULL) {
device_printf(parent, "No usable configuration record found\n");
goto ddf_out;
}
--Dxnq1zWXvFF0Q93v--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120415110807.GA75306>