Date: Wed, 24 Oct 2012 10:05:38 -0400 From: John Baldwin <jhb@freebsd.org> To: Andre Oppermann <andre@freebsd.org> Cc: mdf@freebsd.org, src-committers@freebsd.org, Bruce Evans <brde@optusnet.com.au>, svn-src-user@freebsd.org Subject: Re: svn commit: r241889 - in user/andre/tcp_workqueue/sys: arm/arm cddl/compat/opensolaris/kern cddl/contrib/opensolaris/uts/common/dtrace cddl/contrib/opensolaris/uts/common/fs/zfs ddb dev/acpica dev/... Message-ID: <201210241005.38977.jhb@freebsd.org> In-Reply-To: <50872624.6060901@freebsd.org> References: <201210221418.q9MEINkr026751@svn.freebsd.org> <CAMBSHm-NYtqL71_5zvKj5RNO%2B-ryc6av760eSwBncgP=1d7%2BmQ@mail.gmail.com> <50872624.6060901@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, October 23, 2012 7:20:04 pm Andre Oppermann wrote:
> On 24.10.2012 00:15, mdf@FreeBSD.org wrote:
> > On Tue, Oct 23, 2012 at 7:41 AM, Andre Oppermann <andre@freebsd.org> wrote:
> >> Struct mtx and MTX_SYSINIT always occur as pair next to each other.
> >
> > That doesn't matter. Language basics like variable definitions should
> > not be obscured by macros. It either takes longer to figure out what
> > a variable is (because one needs to look up the definition of the
> > macro) or makes it almost impossible (because now e.g. cscope doesn't
> > know this is a variable definition.
>
> Sigh, cscope doesn't expand macros?
>
> Is there a way to do the cache line alignment in a sane way without
> littering __aligned(CACHE_LINE_SIZE) all over the place?
I was hoping to do something with an anonymous union or some such like:
union mtx_aligned {
struct mtx;
char[roundup2(sizeof(struct mtx), CACHE_LINE_SIZE)];
}
I don't know if there is a useful way to define an 'aligned mutex' type
that will transparently map to a 'struct mtx', e.g.:
typedef struct mtx __aligned(CACHE_LINE_SIZE) aligned_mtx_t;
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210241005.38977.jhb>