Date: Wed, 31 Oct 2012 09:03:50 +0000 From: Eric Wong <normalperson@yhbt.net> To: sox-devel@lists.sourceforge.net Cc: freebsd-multimedia@freebsd.org Subject: Re: [SoX-devel] Bug in sox-14.3.2/src/oss.c Message-ID: <20121031090350.GA8165@dcvr.yhbt.net> In-Reply-To: <201210281324.36923.hselasky@c2i.net> References: <201210281324.36923.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hans Petter Selasky <hselasky@c2i.net> wrote: > Hi, > > Line buffering should be off, but this statement leads to SOX reading 1 and > one byte from the recording DSP device under FreeBSD: > > /* Change to non-buffered I/O */ > setvbuf(ft->fp, NULL, _IONBF, sizeof(char) * file->size); > return(SOX_SUCCESS); > > I think this flag should be used instead: > > _IOFBF fully buffered > > I've tested this change and it works like expected. > > Any comments? The code you're changing in src/oss.c no long applies to SoX 14.4.0, how does 14.4.0 work out-of-the-box for you?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121031090350.GA8165>