Date: Sat, 1 Dec 2012 23:30:49 +0100 From: Mateusz Guzik <mjguzik@gmail.com> To: Hiroki Sato <hrs@FreeBSD.org> Cc: ae@FreeBSD.org, adrian@FreeBSD.org, rpaulo@FreeBSD.org, freebsd-net@FreeBSD.org Subject: Re: LOR in rtsock/ifnet Message-ID: <20121201223049.GA12120@dft-labs.eu> In-Reply-To: <20121202.065436.1086216324076847740.hrs@allbsd.org> References: <CAJ-Vmo=UMDif-56yagEd8WXsNOfiLE0NoyGLsXFCDRBtz0acSg@mail.gmail.com> <20121201133609.GA5450@dft-labs.eu> <20121201.225004.2232262673795057435.hrs@allbsd.org> <20121202.065436.1086216324076847740.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 02, 2012 at 06:54:36AM +0900, Hiroki Sato wrote: > Hiroki Sato <hrs@freebsd.org> wrote > in <20121201.225004.2232262673795057435.hrs@allbsd.org>: > > hr> Mateusz Guzik <mjguzik@gmail.com> wrote > hr> in <20121201133609.GA5450@dft-labs.eu>: > hr> > hr> mj> On Fri, Nov 30, 2012 at 11:16:25PM -0800, Adrian Chadd wrote: > hr> mj> > Mateusz: are you sure it's that commit? > hr> mj> > > hr> mj> > hr> mj> Yes, I double-checked right now. > hr> mj> > hr> mj> > I still get this in -HEAD: > hr> mj> > > hr> mj> > hr> mj> Maybe I expressed myself incorrectly, I meant to say that LOR started > hr> mj> showing up since r243187. > hr> mj> > hr> mj> The code is still in head and no fixes were comitted (that I know of at > hr> mj> least), so I guess that you seeing this LOR on head is expected. :) > hr> > hr> Thanks for the info. I am investigating this now. > > Can anyone test the attached patch and let me know if the LOR > persists or not? > I got the following build failure: /srv/repos/freebsd/sys/netinet6/in6_cksum.c:69:22: error: sys/vnet.h: No such file or directory In file included from /srv/repos/freebsd/sys/netinet6/in6_cksum.c:72: /srv/repos/freebsd/sys/netinet6/scope6_var.h:45: error: expected declaration specifiers or '...' before 'deembed_scopeid' cc1: warnings being treated as errors /srv/repos/freebsd/sys/netinet6/scope6_var.h:45: warning: data definition has no type or storage class /srv/repos/freebsd/sys/netinet6/scope6_var.h:45: warning: type defaults to 'int' in declaration of 'VNET_DECLARE' However after changing sys/vnet.h to net/vnet.h the kernel compiled fine and LOR is gone. -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121201223049.GA12120>