Date: Fri, 18 Jan 2013 15:19:54 +0200 From: Jaakko Heinonen <jh@FreeBSD.org> To: Alexander Motin <mav@FreeBSD.org> Cc: satan@ukr.net, Gleb Smirnoff <glebius@FreeBSD.org>, freebsd-current@FreeBSD.org Subject: Re: panic after r244584 Message-ID: <20130118131954.GA3868@a91-153-116-96.elisa-laajakaista.fi> In-Reply-To: <50F9357F.8040109@FreeBSD.org> References: <20130118073600.GA70874@hell.ukr.net> <20130118094424.GD2331@FreeBSD.org> <50F93165.60809@FreeBSD.org> <20130118113934.GA60441@hell.ukr.net> <50F9357F.8040109@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2013-01-18, Alexander Motin wrote: > > AM> > V> panic: make_dev_alias_v: bad si_name (error=22 si_name=enc@n5003048000bab37d/tpe0/slot@1/elmdesc@Slot 01/pass7) > > AM> The panic is triggered by the check added by the recent r244584 change. > > AM> The space in device name came from the enclosure device, and I guess it > > AM> may be quite often situation. Using human readable name supposed to help > > AM> system administrators, but with spaces banned that may be a problem. > > > > That's was not created by human, it was generated (I think so) by system. > > These strings are flashed into enclosure firmware by manufacturer. You can't rely on that any string can be safely used as a device name even if spaces were allowed. Consider for example duplicate names and "../". Where these names are generated? The original report didn't contain a backtrace. -- Jaakko
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130118131954.GA3868>