Date: Sun, 17 Mar 2013 01:35:59 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: freebsd-arch@FreeBSD.org Subject: chflags(2)'s flags argument. Message-ID: <20130317003559.GA1364@garage.freebsd.pl>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Hi. Currently this is a bit messy: chflags(2) and fchflags(2) take 'flags' argument of type unsigned long and lchflags(2) takes the same argument of type int. At least this is what you can see in manual page and in prototypes of those functions in sys/stat.h. However all of those syscalls are defined in syscalls.master to take the 'flags' argument of type int and this is what they use in kernel. I'd like to proposed the following patch: http://people.freebsd.org/~pjd/patches/chflags_int.patch It changes type of the 'flags' argument from unsigned long to int where possible. I believe this change won't break ABI, as the syscalls (apart from the prototypes) already expect int and I hope in doesn't break API in any really visible and destructive way. If you think otherwise, let me know. Note that the patch doesn't touch the strtofflags(3) function, as I believe it would break ABI and it doesn't touch the fflagstostr(3) function to stay consistent with strtofflags(3). PS. Manual page text provided by jilles. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlFFD+8ACgkQForvXbEpPzTKWgCeIJol+6BESq0STfoPPrnEZ/Ls WfYAoMNwytFHvNwQ+K6uI/oH6ZGmYnm8 =CzyV -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130317003559.GA1364>