Date: Thu, 9 May 2013 19:04:33 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Jim Ohlstein <jim@ohlste.in> Cc: freebsd-stable@freebsd.org Subject: Re: Apparent regression in r250359 Message-ID: <20130509160433.GW3047@kib.kiev.ua> In-Reply-To: <518BC3E4.1030104@ohlste.in> References: <518A880C.3090906@ohlste.in> <20130509053055.GM3047@kib.kiev.ua> <518BAEFB.5090204@ohlste.in> <20130509143038.GV3047@kib.kiev.ua> <518BC3E4.1030104@ohlste.in>
next in thread | previous in thread | raw e-mail | index | archive | help
--dokHZ4yyOnLbJiR1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, May 09, 2013 at 11:42:28AM -0400, Jim Ohlstein wrote:
> On 05/09/13 10:30, Konstantin Belousov wrote:
> > On Thu, May 09, 2013 at 10:13:15AM -0400, Jim Ohlstein wrote:
> >> # sysctl hw.model
> >> hw.model: AMD FX(tm)-8350 Eight-Core Processor
> > Ahh, so it seems that this is a CPU with the LWP.
> > Please try the patch at the end of message.
>=20
> Same error
>=20
> >
> > As another workaround, which does not disable AVX support, you
> > could try loader tunable hw.xsave_mask=3D0x7.
>=20
> This works
Hm, I see another bug in the next line as well. Could you try this
updated patch ?
diff --git a/sys/amd64/amd64/fpu.c b/sys/amd64/amd64/fpu.c
index de79baa..9bc8a2f 100644
--- a/sys/amd64/amd64/fpu.c
+++ b/sys/amd64/amd64/fpu.c
@@ -687,8 +687,8 @@ fpugetregs(struct thread *td)
offsetof(struct xstate_hdr, xstate_bv));
max_ext_n =3D flsl(xsave_mask);
for (i =3D 0; i < max_ext_n; i++) {
- bit =3D 1 << i;
- if ((*xstate_bv & bit) !=3D 0)
+ bit =3D 1ULL << i;
+ if ((xsave_mask & bit) =3D=3D 0 || (*xstate_bv & bit) !=3D 0)
continue;
bcopy((char *)fpu_initialstate +
xsave_area_desc[i].offset,
--dokHZ4yyOnLbJiR1
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iQIcBAEBAgAGBQJRi8kQAAoJEJDCuSvBvK1BoBwP/0Anmhlt8ca8Cc4rANdT1rbg
dIio0nBwgtzH5465H+ZV7rm0X0ofcpev2JhjWOH/RyDg/jaBgBeDEwffBZIT2qmV
lLohV7yy/56fihCER6zVr8IR4OCmrR0+f2LyKCUnnfd2JbnKdwzVOYR8wqQzEhSP
t9g0JkQJSe05PB2CG/uTUAYymixOiMlfGcVrzHnvSP/OGEqrcYBDsUqEZDqYdjCe
7nvFDzW+rl2dQeGu1ndEowWlkfwoJIOYetetVO7nQ7SXP2aqskVXUosJ1J3Qfghr
vomiEHm23QWxjzNArC1NVj8IBk14D+/hGDhyaMvG9FFKC5Z7771l7yxWFlW7um+H
f83+mN8oXLHOZDGHlFgemkVwjfDe2pWRKEwP9RelgA8uR1bE6e+wJrPLGwxH7BUE
Md4byEwZIg0Gk2iVGPud9G8aUXIRdR7s7ru6v4+hW6ZUcNxxn/x2QYRopm+tNhlO
xW5TbK6U1k9Xkacu+NL5IOgzqidopOMAKFsWKo1uQscHoUrngUmIjn9sse9KlaNh
u6hCJ+bEeqvsCp9EcvMbEYLOD3rpuCG+dq/6taZ1kOIAOxylz7E2JqXclS2OMvri
x+Xde/SdyMBqiKmJ7JRy2k5ficBTD5wZ4FPVTqJjSUGZfs1FfEC8CGX/iav7A0pf
1jdsUVZCRzlM7zITr5Gi
=8AEX
-----END PGP SIGNATURE-----
--dokHZ4yyOnLbJiR1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130509160433.GW3047>