Date: Sat, 22 Jun 2013 03:00:25 -0400 From: Mark Johnston <markj@freebsd.org> To: Jeff Ford <jeff.ford@gmail.com> Cc: freebsd-dtrace@freebsd.org Subject: Re: Patch for the trap handler and some test list sanity Message-ID: <20130622070025.GA14663@charmander.mks.com> In-Reply-To: <CAJ0x7rOiY_6z_1obs4N78EPh%2B_prWAVSgCSvywBZb%2BZBZ0342g@mail.gmail.com> References: <CAJ0x7rOiY_6z_1obs4N78EPh%2B_prWAVSgCSvywBZb%2BZBZ0342g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 21, 2013 at 11:47:43AM -0700, Jeff Ford wrote: > Anton Rang and I did some DTrace work for Isilon that we're trying to get > back into FreeBSD, but neither of us is a committer - here's the first one. > > This moves the check for dtrace trap handlers into the low-level exception > handler to prevent recursive entry when the trap routine is instrumented. > This fixes several tests which previously panicked including > cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/safety/tst.basename.d. > The fix is AMD64 only – neither of us has had time to make changes to i386 > code as we don’t use it here. > > Also this includes updates to the Makefile for the DTrace tests to > categorize which ones pass, which ones fail, which ones aren’t safe to run > at all, and which ones sometimes pass and sometimes fail. The list should > be correct for both AMD64 and i386. This makes “make”, “make ignore”, and > “make flaky” safe to run in /tools/test/dtrace. Hello, I'd be happy to help bring these in. I'll probably need some help reviewing the first one, but "improve the DTrace test makefile" has been on my todo list for a while. Are they available somewhere? -Mark
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130622070025.GA14663>