Date: Sat, 3 Aug 2013 17:10:45 -0700 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Glen Barber <gjb@FreeBSD.org> Cc: freebsd-current@freebsd.org Subject: Re: svn error during 'make buildkernel'? Message-ID: <20130804001045.GA1500@troutmask.apl.washington.edu> In-Reply-To: <20130803224719.GP78299@glenbarber.us> References: <20130803210348.GA715@troutmask.apl.washington.edu> <20130803210858.GJ78299@glenbarber.us> <20130803213023.GA812@troutmask.apl.washington.edu> <20130803214313.GL78299@glenbarber.us> <20130803221702.GA979@troutmask.apl.washington.edu> <20130803222047.GN78299@glenbarber.us> <20130803224608.GA1150@troutmask.apl.washington.edu> <20130803224719.GP78299@glenbarber.us>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 03, 2013 at 06:47:19PM -0400, Glen Barber wrote: > On Sat, Aug 03, 2013 at 03:46:08PM -0700, Steve Kargl wrote: > > On Sat, Aug 03, 2013 at 06:20:47PM -0400, Glen Barber wrote: > > > On Sat, Aug 03, 2013 at 03:17:02PM -0700, Steve Kargl wrote: > > > > > > > > BTW, you should upgrade devel/subversion anyway, since there are > > > > > security vulnerabilities. > > > > > > > > 1.7.9 works/worked fine for updating my /usr/src and my personal > > > > svn repository. The change to use svnlite in newvers.sh should > > > > have an entry in UPDATING to alert users that have a too old > > > > svn port that they need to upgrade. I go as far to suggest that > > > > that the script should look for svn in the path before it looks > > > > for svnlite. > > > > > > I cannot differentiate what version of svn is used to check out the > > > tree. When in doubt, software in base wins, IMHO. > > > > You don't need to differentiate anything. devel/subversion > > installs svnversion. svnversion simply needs to be in $PATH. > > If newvers.sh can't find svnversion in $PATH, then it can fall > > back to /usr/bin/svnliteversion. The install svnversion from > > devel/subversion will in all likelihood be consistent with the > > svn used to checkout/update /usr/src. > > > > No, because you can set WITH_SVN=1 in src.conf, and svnlite will install > as svn. If someone set WITH_SVN=1, then more than likely she has already checked out/upgraded a /usr/src with the newly anointed 1.8.0 and she has de-installed devel/subversion. So, newsver.sh looks for svnversion in $PATH. It will find svnversion from the WITH_SVN=1 setting, the svnversion from devel/subversion in $PATH, or no svnversion. If it can't find a svnversion at all, the script falls back to looking for a svnliteversion. If the script can't find svnversion or svnliteversion, then it issues an error. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130804001045.GA1500>