Date: Thu, 5 Sep 2013 21:39:42 +0200 From: Tijl Coosemans <tijl@coosemans.org> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: bapt@FreeBSD.org, Alexey Dokuchaev <danfe@FreeBSD.ORG>, freebsd-bugs@FreeBSD.ORG Subject: Re: bin/178819: bmake w/ WRKDIRPEFIX=/tmp breaks Ports Collection Message-ID: <20130905213942.007a0040@kalimero.tijl.coosemans.org> In-Reply-To: <20130905185758.7D04D5807E@chaos.jnpr.net> References: <201309030703.r8373BSU072280@freefall.freebsd.org> <20130905164552.3639E5807E@chaos.jnpr.net> <20130905175936.GB58718@FreeBSD.org> <20130905185758.7D04D5807E@chaos.jnpr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/wJHGqPEzSyPPBfHtCiVSGT3
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
On Thu, 5 Sep 2013 11:57:58 -0700 Simon J. Gerraty wrote:
>=20
> On Thu, 5 Sep 2013 17:59:36 +0000, Alexey Dokuchaev writes:
> >Yes, I've seen the fresh import; will test it tomorrow. I'm not sure wh=
at
> >is the problem, but "ports should be able to control the value of MAKEFI=
LE
> >as desired" looks strange. MAKEFILE is one of the standard bsd.port.mk's
>=20
> bmake treats MAKEFILE the same way old sysV make did, it gets set to the=
=20
> name of the [mM]akefile read.
> This is obviously something fmake never did, and ports relies on being
> able to set the variable.
fmake does set it. It goes something like this:
1) the port makefiles are all named Makefile so fmake sets
MAKEFILE=3DMakefile. With bmake this is sometimes an absolute path.
2) bsd.port.mk has MAKEFILE?=3DMakefile which doesn't do anything under
both fmake and bmake because it's already defined.
3) bsd.port.mk runs something like "cd ${WRKSRC} && make -f ${MAKEFILE}"
This fails with bmake if MAKEFILE happens to be an absolute path
pointing to the port makefile (instead of the source code makefile).
With fmake this only works by accident.
bsd.port.mk should not try to reuse MAKEFILE like this. I once looked
into renaming this variable to MAKE_FILE but that affects many ports.
--Sig_/wJHGqPEzSyPPBfHtCiVSGT3
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.21 (FreeBSD)
iF4EAREIAAYFAlIo3gIACgkQfoCS2CCgtisNuAD9FMHk9G59DprGSTWOuqPMNgHT
EwCksBpOuSHAKQP/dC4A/jd1QsYW/M2Onzq03alQAj5tRV9N/pQAOeI45R4dWsU6
=HBx2
-----END PGP SIGNATURE-----
--Sig_/wJHGqPEzSyPPBfHtCiVSGT3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130905213942.007a0040>