Date: Wed, 18 Sep 2013 17:24:27 -0700 From: Kirk McKusick <mckusick@mckusick.com> To: "Teske, Devin" <Devin.Teske@fisglobal.com> Cc: freebsd-fs <freebsd-fs@freebsd.org>, bug-followup@freebsd.org Subject: Re: kern/182181: [ufs] Leakage of vnode references (race condition?) Message-ID: <201309190024.r8J0ORZD097969@chez.mckusick.com> In-Reply-To: <13CA24D6AB415D428143D44749F57D720FBD7C18@LTCFISWMSGMB21.FNFIS.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> From: "Teske, Devin" <Devin.Teske@fisglobal.com> > To: Rick Macklem <rmacklem@uoguelph.ca> > Subject: Re: kern/182181: [ufs] Leakage of vnode references (race condition?) > Date: Thu, 19 Sep 2013 00:11:03 +0000 > Cc: freebsd-fs <freebsd-fs@freebsd.org>, > "Teske, Devin" <Devin.Teske@fisglobal.com> > > On Sep 18, 2013, at 5:05 PM, Rick Macklem wrote: > >> Devin Teske wrote: >>> >>> >>> Yes, my confusion was... >>> >>> 1. The PR headers say 8.4-RELEASE-p3 is affected >>> >>> 2. The PR's "How-To-Repeat" starts with "Install a releng/8.4 branch" >>> >>> Yet... >>> >>> releng/8.4 and even releng/8.3 both use VOP_UNLOCK instead of vput >>> (read: are patched). >>> >> Did you mean "not patched"? The patched version in head has vput() >> and the unpatched versions have VOP_UNLOCK(), if I read the coed correctly. >> > > Well, Kirk's fat-finger made me think that VOP_UNLOCK was the patched- > state and vput was the unpatched state. (could also be that I'm fighting > the flu currently). > > So everything is copacetic now, except the one outstanding question... > > Should we not MFC r253998 to stable/8? > > I'm looking to pull this into our own stable/8 kernel, but would > like to do it by way of svn merge from the stable/8 branch. > -- > Devin Per your request, I have MFC'ed the patch to 8-stable as revision 255681. Kirk McKusick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201309190024.r8J0ORZD097969>