Date: Mon, 23 Sep 2013 10:23:53 +0200 From: Tijl Coosemans <tijl@FreeBSD.org> To: gahr@gahr.ch Cc: freebsd-ports@freebsd.org, David Wolfskill <david@catwhisker.org> Subject: Re: Help understanding ports tinderbox failure report? Message-ID: <20130923102353.3cd4cfb3@kalimero.tijl.coosemans.org> In-Reply-To: <20130923080810.GC25610@gahrfit.gahr.ch> References: <20130923005528.GA1616@albert.catwhisker.org> <20130923080810.GC25610@gahrfit.gahr.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/Ns3AR7Gfv78864v3J6pYk3F
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
On Mon, 23 Sep 2013 10:08:11 +0200 Pietro Cerutti wrote:
> On 2013-Sep-22, 17:55, David Wolfskill wrote:
>> Back in July, I filed PR ports/180642 (as the port maintainer for
>> astro/gpsman) to update that port from 6.4.4 to 6.4.4.1.
> [snip]
>> I've attached a revised patch, to:
>> * Perform the 6.4.4 -> 6.4.4.1 upgrade.
>> * Replace the "USE_TK_RUN" (& "USE_TK_WRAPPER") with "USES+=3D tk:wrappe=
r,run".
>> * Avoid showing the pkg-message if NOPORTDOCS is defined.
>=20
> please find attached a revised patch, including:
>=20
> - the update to 6.4.4.1
> - update to the new OPTIONS framework (s|NOPORTDOCS|!${PORTOPTIONS:MDOCS})
> - install man pages along with docs
> - fix wish and datadir paths in gpsman.tcl
>=20
> Approved?
The tinderbox build also defined NOPORTDATA. This variable makes little
sense, but you could support it in the do-install target (don't install
${PREFIX}/share/gpsman (aka ${DATADIR})).
Since you converted NOPORTDOCS, could you also add OPTIONS_DEFINE=3DDOCS?
Manpages are always installed I think. If they are optional they fall
under the MANPAGES option.
--Sig_/Ns3AR7Gfv78864v3J6pYk3F
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.21 (FreeBSD)
iF4EAREIAAYFAlI/+p0ACgkQfoCS2CCgtis/WwD+Iwshfc4ecW8vIu3oPsTLmtrZ
6zgvArbG9idRjnHWPtYA/01SJR+Rfvqvvwv2PSdy+FAltuXF3Y2m9VaJObiB4+mr
=gb7t
-----END PGP SIGNATURE-----
--Sig_/Ns3AR7Gfv78864v3J6pYk3F--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130923102353.3cd4cfb3>