Date: Thu, 14 Nov 2013 08:00:26 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Andreas Tobler <andreast@FreeBSD.org> Cc: Current <freebsd-current@FreeBSD.org>, brde@optusnet.com.au Subject: Re: WEAK_REFERENCE? Message-ID: <20131114060026.GH59496@kib.kiev.ua> In-Reply-To: <5283ECA3.4080502@FreeBSD.org> References: <527EB428.6070104@FreeBSD.org> <20131111074706.GK59496@kib.kiev.ua> <5283ECA3.4080502@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--NW8tLX0+7pBPLam0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 13, 2013 at 10:18:27PM +0100, Andreas Tobler wrote: > On 11.11.13 08:47, Konstantin Belousov wrote: > > On Sat, Nov 09, 2013 at 11:16:08PM +0100, Andreas Tobler wrote: > >> Hi all, > >> > >> anyone interested in this patch to remove the WEAK_ALIAS and introduce > >> the WEAK_REFERENCE? > >> > >> http://people.freebsd.org/~andreast/weak_ref.amd64.diff > >> > >> I have this running since months on amd64 and I have no issues with. > >> > >> I remember having had a communication with bde@ that he is in favour in > >> doing that but I lacked the time to complete. > >> A similar thing is pending for i386 and sparc64. The ppc stuff is > >> already committed since a longer time. > >> > >> If no one is interested, I'm happy to clean up my tree and skip this. > >=20 > > I am not sure why do you include the changes to END() in the same patch. > > Did you looked over the all END() usages on amd64, is it always paired > > with ENTRY() ? The CNAME() for ELF is the pedantism anyway. > >=20 > > Other than the somewhat questionable inclusion of the END() change, whi= ch > > should be committed separately, if ever, I think the change is fine. >=20 > Am I correct, without this line in sys/amd64/include/asm.h? >=20 > #define END(name) .size CNAME(name), . - CNAME(name) Yes. If committing it, please make separate commit. >=20 > If so, I just need a usable dot.emacs file to match the formatting > expectations from bde. Sounds easy, but I didn't succeed so far. Nah, cannot be. Emacs source code has too many inconsistencies, the code does not follow its own style. I doubt Bruce would use it. --NW8tLX0+7pBPLam0 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJShGb5AAoJEJDCuSvBvK1B/nYQAKXufI4SzXM1d1G+KyBUI/pt Z9rwMVMBmC+4QJpTsHM1pOPWlt10YMI7FcwExPZGu6c93LeOHaqGkz9Z+VBvFgc1 p8xir7ztglGv3dnYKAXaxqTqOIv0scvgv0tfBuMldgBwAqbB9dojK7lQyKP3Pbv5 lDBCYyxRG0SF2/Giss7u/zB+g+laOVkRSxJbQg6U/oozzvG2RYGZ+ygdEIFRF9EA K67Wok0jr6+aYWtATe7ZiLT9AiUyY3GF9bf5fa2nhvTD1Bkepw/5LoZVvnHGITVs JwvZRq3N2+nSOW7YxuTF0TNuR4x/NZ5hKvi1OSdmJaYU96VrsQAgd67iYM88vLEA i1eggsEEej/ooKgYUhn1c5zaI6DUYoWWY4cftOczHRbZo/TtcPtgmrJkQOW2lIjQ bFZmOQo/p+Sf1W96eqCkeMnfh5ERM0a/RNqBf7NptZGGXICEhB8tZZ3f18UHVIqV zXLhyqkpEFs2c24AmQWOEAJ9IjtLkUGlZqarb8UYyYjvjXVTsBuI2pZJTtq3dona rZne0NxbYzjTbs/nz//ipum3cB6PZQbn88V5TwaARsgiNKjYCDTsLUpF3mqzDOSn QOEQ9LCs9ZsBOlxuwQ1Ao1+sYMFG8jV+ex7A99TjiHtFsBf1foKwAVJ4vG4MKGS9 TQOwwbgaAi9iJdBqvIjD =2+CE -----END PGP SIGNATURE----- --NW8tLX0+7pBPLam0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131114060026.GH59496>