Date: Tue, 19 Nov 2013 09:23:12 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Andreas Tobler <andreast@FreeBSD.org> Cc: Current <freebsd-current@FreeBSD.org>, brde@optusnet.com.au Subject: Re: WEAK_REFERENCE? Message-ID: <20131119072312.GW59496@kib.kiev.ua> In-Reply-To: <528A8E17.5090307@FreeBSD.org> References: <527EB428.6070104@FreeBSD.org> <20131111074706.GK59496@kib.kiev.ua> <5283ECA3.4080502@FreeBSD.org> <20131114060026.GH59496@kib.kiev.ua> <528A8E17.5090307@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--gkqX2/sFY1Elt32G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 18, 2013 at 11:00:55PM +0100, Andreas Tobler wrote: > I prepared two patches, see below. The amd64 one is reviewed by bde@ and > the i386 is compile tested by me (runtime is theoretically also done, > but I'm not sure since I do not have 32-bit apps on my amd64). Use cc -m32. >=20 > The amd64 is compile and runtime tested. The tools, nm, shows that we > have the weak_references as before. >=20 > If you agree I'd like to commit both within a few days to -CURRENT. If > someone steps up and confirms that the i386 part also runs, would be > great, but I expect it to work. >=20 > If I'm correct, there is some similar work to be done on arm, mips and > sparc64, I'm happy to do this if the people like to have it done. But I > do not own either of them to test in native config. Except sparc64..... > Here I have blech ;) >=20 >=20 > Here the two patches > amd64: > http://people.freebsd.org/~andreast/weak_ref_amd64.diff > i386: > http://people.freebsd.org/~andreast/weak_ref_i386.diff Amd64 patch is fine. For i386, I do not see a definition of the WEAK_REFERENCE in the patch, and quick search of the pre-existing definition in sys/i386 or lib/libc/i386 does not reveal anything. --gkqX2/sFY1Elt32G Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJSixHgAAoJEJDCuSvBvK1B0KoP/1Gt5Keoc++RgWcdQTdH8G3q /tDeV+w7eANs8TP6yPaWq4zrF1U4qjqJN7rDgoQfRaEgyPSX/k1SF9HDJu7zT9JJ 28a+jwxQC1NtfLN7fzSjG4t46GTzQKQiDceyRabgxm+ABkwr2rsjfXiigrVWwePS OUGoYJyYz3x+I6i+FmOmPX3AudNee81JDYC5E0vzxLo8wSzeEIC5l9EhobqoKF21 ht2vyhvXRgPVSSA/dWXxm9qsUf0BqBqPZbdfiA0sqG7EUVbWcLsDaTlHjc3mx1zh rQm3VKzBTwhEZktc+rg1Soz302JPOAKokwb4KFBwnBqWOQcvVPmy8V08dY+nr0xM nQE6x0VaUcYBRPehtbF0J5o6yaUnRMI0Rxos5zJJzWj5cVK172xSP2YYPj1xf51a ib/RFCGgJhq+GbAmrepat9aiW50cQR9SkYujz2Rbg6HBx2/Qo1ccGsNyVjSACKp0 Pl99u2kSL4mi+hw0GdSALA7PmIJs/5o0NrOAagYnDveSvXB6hkYqEWr/3i/PaeNH Igsl9aKjIUNO2/KYFsyxCilkwZmsAHy65oEDcih6hxi9DBQh3fteEOz9E1mgz3os ALUanAHkQ5p86wgnx0+FnaxxX8O1pHqrQUsS1VelGMho802ogJ60QIxcK1sZfMIx bempidnvv213rcPoXGvh =FVvc -----END PGP SIGNATURE----- --gkqX2/sFY1Elt32G--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131119072312.GW59496>