Date: Mon, 2 Dec 2013 10:20:54 -0500 From: Glen Barber <gjb@FreeBSD.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: src-committers@FreeBSD.org, svn-src-user@FreeBSD.org Subject: Re: svn commit: r258848 - user/hrs/releng/release Message-ID: <20131202152054.GH1839@glenbarber.us> In-Reply-To: <20131203.001628.1233827032249325723.hrs@allbsd.org> References: <201312021440.rB2EeQa6012210@svn.freebsd.org> <20131202145103.GG1839@glenbarber.us> <20131203.001628.1233827032249325723.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--wj9ZLJVQDRFjGSdK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 03, 2013 at 12:16:28AM +0900, Hiroki Sato wrote: > gj> On Mon, Dec 02, 2013 at 02:40:26PM +0000, Hiroki Sato wrote: > gj> > Author: hrs > gj> > Date: Mon Dec 2 14:40:26 2013 > gj> > New Revision: 258848 > gj> > URL: http://svnweb.freebsd.org/changeset/base/258848 > gj> > > gj> > Log: > gj> > Improve robustness and consistency, and remove redundant lines wi= th no > gj> > major functional change: > gj> > gj> > [...] > gj> > gj> > +if [ $($ID -u) -ne 0 ]; then > gj> > + echo 1>&2 "$0: Needs to be run as root." > gj> > + exit 1 > gj> > +fi > gj> > # The directory within which the release will be built. > gj> > -CHROOTDIR=3D"/scratch" > gj> > +: ${CHROOTDIR:=3D/scratch} > gj> > +: ${CHROOT_CMD:=3Dchroot $CHROOTDIR} > gj> > +: ${DESTDIR=3D:/R/} > gj> > +: ${MAKEOBJDIRPREFIX:=3D/usr/obj} > gj> > > gj> > gj> Please do not merge these changes to head/. It was intentional that > gj> environment was not honored, as everything should be set in the > gj> configuration file. > gj> > gj> It is possible to use the environment in the configuration file, such > gj> as: > gj> > gj> ---- release.conf ---- > gj> : ${_DESTDIR=3D:/R/} > gj> DESTDIR=3D${_DESTDIR} > gj> ---- release.conf ---- >=20 > Everything can be overridden by a configuration file regardless of > whether envvars are honored even after this change. What is the > problem? I do not see negative effect assuming a conf file is used. >=20 This allows the host environment to accidentally pollute the build if something is not set in configuration file and unintentionally set in the builder's environment. It was why I specifically did not allow the environment to affect the build process. Glen --wj9ZLJVQDRFjGSdK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBCAAGBQJSnKVWAAoJELls3eqvi17QGxIQAKs5GXnsepgdvZ65TVYOv3G0 iKtsEIn9VzV6jUlVI9MlVyu9TY5YattZTgqySMq/TWn9uZ7bAUGrrnn2JOFKSVE1 U2YIU8OaGt9sq8WDSpHL22gGIie/BzTullRtSC8xiIjan8d7u06+PrHbKBEh7TrX 5lWcKlo1jn0TVZX/0FT7SqotObksAvPdyeuC7uDJqWqaQf7xE/QndBtz8/gty++e LKsaMRORlu5qclm2LIkbMFWlu1q62FpuUTKkOuWImhKPJ6Nb+K/zexMJ6AEiZ7TU fRbVVnRW+56MRjALv1Z9wJkmxxeIzdDTZZAyAW5U3/xjNiXUyEsgV+IXggjc90Hr HN1LIBTcTL+LGSePc4gRYpON3Nu4m3+RwpaUqA67IYu9W6GT7XUnr7xAIKhG+rwQ b64lqLs/GfCpov786ZZpa4LIqvA5Ss/o/G+XMsO9nyZuM0w1v3Zu+9Pzwm/Cc7I8 cyyZgSO3+AdaAsuhwSzrZBZWROW6z5UJcGUS7rs2nM4aMLT8kdlDxG2gmAblkMYe G6N8jZLI4pTkIZTkGzMip2bW9JxZgCtQTnJRWIMBuYQJzp/xz06RO/m9GVgRUMPZ 7UNQzDOB+ZJqHN76pCDKoXYGbhcYyxPGp0sRrYBFhYP5sNG/Ecg+vvwdmj5WnD1x Wns2PwQ1IXc900XEGSx2 =0zrq -----END PGP SIGNATURE----- --wj9ZLJVQDRFjGSdK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131202152054.GH1839>